[gnome-shell-extensions/wip/fmuellner/fix-113-master] workspace-indicator: Don't override ClutterActor.destroy()
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell-extensions/wip/fmuellner/fix-113-master] workspace-indicator: Don't override ClutterActor.destroy()
- Date: Wed, 10 Oct 2018 19:00:20 +0000 (UTC)
commit 9559612038987aeada49ba681aa98a861d231892
Author: Florian Müllner <fmuellner gnome org>
Date: Wed Oct 10 20:54:53 2018 +0200
workspace-indicator: Don't override ClutterActor.destroy()
Now that PanelMenu.Button was made an StWidget subclass, the destroy()
method actually maps to the ClutterActor method, and overriding it
results in warnings when the extension is disabled. So instead, use
the existing ::destroy handler.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/113
extensions/workspace-indicator/extension.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/extensions/workspace-indicator/extension.js b/extensions/workspace-indicator/extension.js
index 9491b83..81a8504 100644
--- a/extensions/workspace-indicator/extension.js
+++ b/extensions/workspace-indicator/extension.js
@@ -59,7 +59,7 @@ class WorkspaceIndicator extends PanelMenu.Button {
this._createWorkspacesSection.bind(this));
}
- destroy() {
+ _onDestroy() {
for (let i = 0; i < this._workspaceManagerSignals.length; i++)
global.workspace_manager.disconnect(this._workspaceManagerSignals[i]);
@@ -68,7 +68,7 @@ class WorkspaceIndicator extends PanelMenu.Button {
this._settingsChangedId = 0;
}
- super.destroy();
+ super._onDestroy();
}
_updateIndicator() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]