[gnome-shell-extensions/wip/fmuellner/fix-113-master] drive-menu: Don't override ClutterActor.destroy()



commit c6d8bf671e066559350faed737293cdfd00e9f9f
Author: Florian Müllner <fmuellner gnome org>
Date:   Wed Oct 10 20:50:54 2018 +0200

    drive-menu: Don't override ClutterActor.destroy()
    
    Now that PanelMenu.Button was made an StWidget subclass, the destroy()
    method actually maps to the ClutterActor method, and overriding it
    results in warnings when the extension is disabled. So instead, use
    the existing ::destroy handler.
    
    https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/113

 extensions/drive-menu/extension.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/extensions/drive-menu/extension.js b/extensions/drive-menu/extension.js
index eaa15df..c8ec0c3 100644
--- a/extensions/drive-menu/extension.js
+++ b/extensions/drive-menu/extension.js
@@ -176,7 +176,7 @@ class DriveMenu extends PanelMenu.Button {
         log ('Removing a mount that was never added to the menu');
     }
 
-    destroy() {
+    _onDestroy() {
         if (this._addedId) {
             this._monitor.disconnect(this._addedId);
             this._monitor.disconnect(this._removedId);
@@ -184,7 +184,7 @@ class DriveMenu extends PanelMenu.Button {
             this._removedId = 0;
         }
 
-        super.destroy();
+        super._onDestroy();
     }
 });
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]