[gnome-shell-extensions/wip/fmuellner/fix-113-master: 9/9] places-menu: Don't override ClutterActor.destroy()



commit 1702cc0be2fc72ef2855bf00f75d42ad5d0678e0
Author: Florian Müllner <fmuellner gnome org>
Date:   Wed Oct 10 16:23:05 2018 +0200

    places-menu: Don't override ClutterActor.destroy()
    
    Now that PanelMenu.Button was made an StWidget subclass, the destroy()
    method actually maps to the ClutterActor method, and overriding it
    results in warnings when the extension is disabled. So instead, use
    the existing ::destroy handler.
    
    https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/113

 extensions/places-menu/extension.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/extensions/places-menu/extension.js b/extensions/places-menu/extension.js
index 94747b1..a83513a 100644
--- a/extensions/places-menu/extension.js
+++ b/extensions/places-menu/extension.js
@@ -105,10 +105,10 @@ class PlacesMenu extends PanelMenu.Button {
         }
     }
 
-    destroy() {
+    _onDestroy() {
         this.placesManager.destroy();
 
-        super.destroy();
+        super._onDestroy();
     }
 
     _redisplay(id) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]