[gimp] app: in GimpBacktrace Windows backend, avoid bogus symbol addresses
- From: Ell <ell src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] app: in GimpBacktrace Windows backend, avoid bogus symbol addresses
- Date: Wed, 10 Oct 2018 14:01:24 +0000 (UTC)
commit 52772cf3ff0bb8cf6554c782cfb78af587545f83
Author: Ell <ell_se yahoo com>
Date: Wed Oct 10 09:58:29 2018 -0400
app: in GimpBacktrace Windows backend, avoid bogus symbol addresses
In the GimpBacktrace Windows backend, avoid reporting meaningless
symbol addresses when failing to retrieve meaningful ones.
Unfortunately, it seems that we never get symbol addresses for
symbols that have debug information, which negatively affects the
log viewer's call graph. We're going to have to work around this.
app/core/gimpbacktrace-windows.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/app/core/gimpbacktrace-windows.c b/app/core/gimpbacktrace-windows.c
index dceb8834a6..9b9e0ee67c 100644
--- a/app/core/gimpbacktrace-windows.c
+++ b/app/core/gimpbacktrace-windows.c
@@ -668,7 +668,7 @@ gimp_backtrace_get_address_info (guintptr address,
g_strlcpy (info->symbol_name, symbol_info->Name,
sizeof (info->symbol_name));
- info->symbol_address = address - offset;
+ info->symbol_address = offset ? address - offset : 0;
result = TRUE;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]