[gnome-software/wip/hughsie/fix-alternates-regression: 4/12] trivial: Do not add the alternate target twice



commit 8801a6a33fb40b5be2e01b83ee64a922b4988b92
Author: Richard Hughes <richard hughsie com>
Date:   Mon Oct 8 17:09:47 2018 +0100

    trivial: Do not add the alternate target twice
    
    gs_plugin_job_set_app() helpfully sets up the GsAppList with the GsApp, so we
    don't need to do it again.

 lib/gs-plugin-loader.c | 1 -
 1 file changed, 1 deletion(-)
---
diff --git a/lib/gs-plugin-loader.c b/lib/gs-plugin-loader.c
index 77ed2547..f8f5cf0a 100644
--- a/lib/gs-plugin-loader.c
+++ b/lib/gs-plugin-loader.c
@@ -3515,7 +3515,6 @@ gs_plugin_loader_job_process_async (GsPluginLoader *plugin_loader,
        if (action == GS_PLUGIN_ACTION_GET_ALTERNATES) {
                GsApp *app = gs_plugin_job_get_app (plugin_job);
                GsAppList *list = gs_plugin_job_get_list (plugin_job);
-               gs_app_list_add (list, app);
 
                /* also add the wildcard match */
                if (!gs_app_has_quirk (app, AS_APP_QUIRK_MATCH_ANY_PREFIX)) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]