[gnome-software] Explicity mark non-visible widgets in GtkBuilder files

From: Robert Ancell <rancell src gnome org>
To: commits-list gnome org
Cc:
Subject: [gnome-software] Explicity mark non-visible widgets in GtkBuilder files
Date: Fri, 5 Oct 2018 02:54:09 +0000 (UTC)
commit 58ec7fb47a3462afe94916912f0712e7c2f4a49e
Author: Robert Ancell <robert ancell canonical com>
Date:   Mon Oct 1 10:24:43 2018 +1300

    Explicity mark non-visible widgets in GtkBuilder files
    
    GTK+ 4 sets visibility to true by default, so we should explicitly mark those as
    non-visible. The visible=True attributes can be removed after migration.

 src/gnome-software.ui   | 12 ++++++++++++
 src/gs-app-addon-row.ui |  1 +
 src/gs-app-row.ui       |  6 ++++++
 src/gs-app-tile.ui      |  1 +
 src/gs-auth-dialog.ui   |  2 ++
 src/gs-category-page.ui |  2 ++
 src/gs-details-page.ui  | 12 ++++++++++++
 src/gs-editor.ui        |  4 ++++
 src/gs-overview-page.ui |  1 +
 src/gs-popular-tile.ui  |  1 +
 src/gs-summary-tile.ui  |  1 +
 src/gs-updates-page.ui  |  1 +
 12 files changed, 44 insertions(+)
---
diff --git a/src/gnome-software.ui b/src/gnome-software.ui
index 23c9693c..11522032 100644
--- a/src/gnome-software.ui
+++ b/src/gnome-software.ui
@@ -18,6 +18,7 @@
     </child>
   </object>
   <object class="GtkPopoverMenu" id="account_popover">
+    <property name="visible">False</property>
     <child>
       <object class="GtkBox" id="account_box">
         <property name="visible">True</property>
@@ -45,6 +46,7 @@
     </section>
   </menu>
   <object class="GtkApplicationWindow" id="window_software">
+    <property name="visible">False</property>
     <property name="can_focus">False</property>
     <property name="default-width">1200</property>
     <property name="default-height">800</property>
@@ -136,6 +138,7 @@
                             </child>
                             <child>
                               <object class="GtkLabel" id="button_installed_counter">
+                                <property name="visible">False</property>
                                 <property name="width-chars">2</property>
                                 <style>
                                   <class name="counter-label"/>
@@ -178,6 +181,7 @@
                             </child>
                             <child>
                               <object class="GtkLabel" id="button_updates_counter">
+                                <property name="visible">False</property>
                                 <property name="width-chars">2</property>
                                 <style>
                                   <class name="counter-label"/>
@@ -201,6 +205,7 @@
                 </child>
                 <child>
                   <object class="GtkLabel" id="application_details_header">
+                    <property name="visible">False</property>
                     <property name="can_focus">False</property>
                     <property name="selectable">False</property>
                     <property name="ellipsize">end</property>
@@ -214,6 +219,7 @@
                 </child>
                 <child>
                   <object class="GtkMenuButton" id="header_selection_menu_button">
+                    <property name="visible">False</property>
                    <property name="popup">header_selection_menu</property>
                    <style>
                       <class name="selection-menu"/>
@@ -415,6 +421,7 @@
                         <property name="visible">True</property>
                         <child>
                           <object class="GtkButton" id="button_events_sources">
+                            <property name="visible">False</property>
                             <property name="label" translatable="yes" comments="button in the info 
bar">Software Repositories</property>
                             <property name="can_focus">True</property>
                             <property name="receives_default">True</property>
@@ -422,6 +429,7 @@
                         </child>
                         <child>
                           <object class="GtkButton" id="button_events_no_space">
+                            <property name="visible">False</property>
                             <property name="label" translatable="yes" comments="button in the info 
bar">Examine Disk</property>
                             <property name="can_focus">True</property>
                             <property name="receives_default">True</property>
@@ -429,6 +437,7 @@
                         </child>
                         <child>
                           <object class="GtkButton" id="button_events_network_settings">
+                            <property name="visible">False</property>
                             <property name="label" translatable="yes" comments="button in the info 
bar">Network Settings</property>
                             <property name="can_focus">True</property>
                             <property name="receives_default">True</property>
@@ -436,6 +445,7 @@
                         </child>
                         <child>
                           <object class="GtkButton" id="button_events_restart_required">
+                            <property name="visible">False</property>
                             <property name="label" translatable="yes" comments="button in the info 
bar">Restart Now</property>
                             <property name="can_focus">True</property>
                             <property name="receives_default">True</property>
@@ -443,6 +453,7 @@
                         </child>
                         <child>
                           <object class="GtkButton" id="button_events_more_info">
+                            <property name="visible">False</property>
                             <property name="label" translatable="yes" comments="button in the info bar">More 
Information</property>
                             <property name="can_focus">True</property>
                             <property name="receives_default">True</property>
@@ -560,6 +571,7 @@
     </child>
   </object>
   <object class="GtkPopover" id="origin_popover">
+    <property name="visible">False</property>
     <child>
       <object class="GtkBox" id="origin_popover_box">
         <property name="visible">True</property>
diff --git a/src/gs-app-addon-row.ui b/src/gs-app-addon-row.ui
index ac81d93a..471d373a 100644
--- a/src/gs-app-addon-row.ui
+++ b/src/gs-app-addon-row.ui
@@ -50,6 +50,7 @@
         </child>
         <child>
           <object class="GtkLabel" id="label">
+            <property name="visible">False</property>
             <property name="margin_start">12</property>
             <property name="width_request">100</property>
             <property name="xalign">1</property>
diff --git a/src/gs-app-row.ui b/src/gs-app-row.ui
index 2452ca3e..eb9665fc 100644
--- a/src/gs-app-row.ui
+++ b/src/gs-app-row.ui
@@ -14,6 +14,7 @@
         <property name="orientation">horizontal</property>
         <child>
           <object class="GtkCheckButton" id="checkbox">
+            <property name="visible">False</property>
             <property name="margin-start">12</property>
             <property name="valign">center</property>
           </object>
@@ -140,6 +141,7 @@
                 <property name="orientation">vertical</property>
                 <child>
                   <object class="GtkLabel" id="label_warning">
+                    <property name="visible">False</property>
                     <property name="can_focus">False</property>
                     <property name="label">warning-text</property>
                     <property name="halign">start</property>
@@ -175,6 +177,7 @@
                     </child>
                    <child>
                      <object class="GtkBox" id="label_installed">
+                        <property name="visible">False</property>
                        <property name="orientation">horizontal</property>
                        <property name="no_show_all">True</property>
                        <property name="halign">end</property>
@@ -231,6 +234,7 @@
                <property name="valign">center</property>
                <child>
                  <object class="GsProgressButton" id="button">
+                    <property name="visible">False</property>
                     <property name="width_request">100</property>
                     <property name="margin-right">6</property>
                     <property name="halign">end</property>
@@ -241,6 +245,7 @@
                </child>
                <child>
                  <object class="GtkSpinner" id="spinner">
+                    <property name="visible">False</property>
                     <property name="margin_start">12</property>
                     <property name="margin_end">12</property>
                     <property name="halign">end</property>
@@ -251,6 +256,7 @@
                </child>
                <child>
                  <object class="GtkLabel" id="label">
+                    <property name="visible">False</property>
                     <property name="margin_start">12</property>
                     <property name="margin_end">12</property>
                     <property name="halign">end</property>
diff --git a/src/gs-app-tile.ui b/src/gs-app-tile.ui
index 3e41e700..e276c407 100644
--- a/src/gs-app-tile.ui
+++ b/src/gs-app-tile.ui
@@ -36,6 +36,7 @@
             <property name="valign">fill</property>
             <child type="overlay">
               <object class="GtkEventBox" id="eventbox">
+                <property name="visible">False</property>
                 <property name="no_show_all">True</property>
                 <property name="visible_window">True</property>
                 <property name="halign">start</property>
diff --git a/src/gs-auth-dialog.ui b/src/gs-auth-dialog.ui
index fe04619d..04cbc96a 100644
--- a/src/gs-auth-dialog.ui
+++ b/src/gs-auth-dialog.ui
@@ -253,6 +253,7 @@
             </child>
             <child>
               <object class="GtkImage" id="image_vendor">
+                <property name="visible">False</property>
                 <property name="can_focus">False</property>
                 <property name="halign">start</property>
                 <property name="valign">start</property>
@@ -267,6 +268,7 @@
             </child>
             <child>
               <object class="GtkBox" id="box_error">
+                <property name="visible">False</property>
                 <property name="can_focus">False</property>
                 <property name="spacing">6</property>
                 <child>
diff --git a/src/gs-category-page.ui b/src/gs-category-page.ui
index ad1a7c3b..7d6ebf04 100644
--- a/src/gs-category-page.ui
+++ b/src/gs-category-page.ui
@@ -2,6 +2,7 @@
 <interface>
   <requires lib="gtk+" version="3.10"/>
   <object class="GtkPopover" id="categories_popover">
+    <property name="visible">False</property>
     <property name="position">bottom</property>
     <child>
       <object class="GtkBox" id="popover_filter_box">
@@ -12,6 +13,7 @@
     </child>
   </object>
   <object class="GtkPopover" id="sorting_popover">
+    <property name="visible">False</property>
     <property name="position">bottom</property>
     <child>
       <object class="GtkBox" id="sorting_popover_box">
diff --git a/src/gs-details-page.ui b/src/gs-details-page.ui
index 14194d46..5f85faed 100644
--- a/src/gs-details-page.ui
+++ b/src/gs-details-page.ui
@@ -186,6 +186,7 @@
                             <property name="spacing">9</property>
                             <child>
                               <object class="GtkButton" id="button_install">
+                                <property name="visible">False</property>
                                 <property name="use_underline">True</property>
                                 <property name="label" translatable="yes">_Install</property>
                                 <property name="width_request">105</property>
@@ -217,6 +218,7 @@
                             </child>
                             <child>
                               <object class="GtkButton" id="button_remove">
+                                <property name="visible">False</property>
                                 <property name="use_underline">True</property>
                                 <property name="label" translatable="yes">_Remove</property>
                                 <property name="width_request">105</property>
@@ -231,6 +233,7 @@
                             </child>
                             <child>
                               <object class="GtkSpinner" id="spinner_remove">
+                                <property name="visible">False</property>
                                 <property name="can_focus">False</property>
                               </object>
                               <packing>
@@ -289,6 +292,7 @@
                             </child>
                             <child>
                               <object class="GtkButton" id="button_cancel">
+                                <property name="visible">False</property>
                                 <property name="use_underline">True</property>
                                 <property name="label" translatable="yes">_Cancel</property>
                                 <property name="width_request">116</property>
@@ -757,6 +761,7 @@
                                 </child>
                                 <child>
                                   <object class="GtkButton" id="button_details_rating_value">
+                                    <property name="visible">False</property>
                                     <property name="use_underline">True</property>
                                     <property name="label">18</property>
                                     <property name="can_focus">True</property>
@@ -1143,6 +1148,7 @@
                         </child>
                         <child>
                           <object class="GtkBox" id="box_reviews">
+                            <property name="visible">False</property>
                             <property name="orientation">vertical</property>
                             <child>
                               <object class="GtkLabel" id="application_details_reviews_title">
@@ -1161,6 +1167,7 @@
                             </child>
                             <child>
                               <object class="GsReviewHistogram" id="histogram">
+                                <property name="visible">False</property>
                                 <property name="halign">start</property>
                                 <property name="valign">center</property>
                                 <property name="margin_bottom">32</property>
@@ -1168,6 +1175,7 @@
                             </child>
                             <child>
                               <object class="GtkButton" id="button_review">
+                                <property name="visible">False</property>
                                 <property name="use_underline">True</property>
                                 <property name="label" translatable="yes" comments="Translators: Button 
opening a dialog where the users can write and publish their opinions about the apps.">_Write a 
Review</property>
                                 <property name="can_focus">True</property>
@@ -1301,6 +1309,7 @@
     </widgets>
   </object>
   <object class="GtkPopover" id="popover_license_free">
+    <property name="visible">False</property>
     <property name="can_focus">False</property>
     <property name="border_width">21</property>
     <property name="relative_to">button_details_license_free</property>
@@ -1369,6 +1378,7 @@
     </child>
   </object>
   <object class="GtkPopover" id="popover_license_nonfree">
+    <property name="visible">False</property>
     <property name="can_focus">False</property>
     <property name="border_width">21</property>
     <property name="relative_to">button_details_license_nonfree</property>
@@ -1424,6 +1434,7 @@
     </child>
   </object>
   <object class="GtkPopover" id="popover_license_unknown">
+    <property name="visible">False</property>
     <property name="name">popover_license_unknown</property>
     <property name="can_focus">False</property>
     <property name="border_width">21</property>
@@ -1467,6 +1478,7 @@
   </object>
 
   <object class="GtkPopover" id="popover_content_rating">
+    <property name="visible">False</property>
     <property name="can_focus">False</property>
     <child>
       <object class="GtkBox" id="box_content_rating">
diff --git a/src/gs-editor.ui b/src/gs-editor.ui
index 89e52daa..d365f49d 100644
--- a/src/gs-editor.ui
+++ b/src/gs-editor.ui
@@ -20,6 +20,7 @@
     <property name="inline_completion">True</property>
   </object>
   <object class="GtkApplicationWindow" id="window_main">
+    <property name="visible">False</property>
     <property name="can_focus">False</property>
     <property name="default_width">1400</property>
     <property name="default_height">700</property>
@@ -425,6 +426,7 @@
                     <property name="layout_style">end</property>
                     <child>
                       <object class="GtkButton" id="button_notification_undo_remove">
+                        <property name="visible">False</property>
                         <property name="label" translatable="yes" comments="button in the info 
bar">Undo</property>
                         <property name="can_focus">True</property>
                         <property name="receives_default">True</property>
@@ -549,6 +551,7 @@
     </child>
   </object>
   <object class="GtkPopover" id="popover_menu">
+    <property name="visible">False</property>
     <property name="can_focus">False</property>
     <property name="border_width">6</property>
     <property name="relative_to">button_menu</property>
@@ -598,6 +601,7 @@
     </child>
   </object>
   <object class="GtkPopover" id="popover_new">
+    <property name="visible">False</property>
     <property name="can_focus">False</property>
     <property name="border_width">6</property>
     <property name="relative_to">button_new</property>
diff --git a/src/gs-overview-page.ui b/src/gs-overview-page.ui
index d07d8ebd..e659dd55 100644
--- a/src/gs-overview-page.ui
+++ b/src/gs-overview-page.ui
@@ -130,6 +130,7 @@
                         </child>
                         <child>
                           <object class="GtkBox" id="box_featured_switcher">
+                            <property name="visible">False</property>
                             <property name="halign">center</property>
                             <property name="can_focus">False</property>
                             <property name="homogeneous">True</property>
diff --git a/src/gs-popular-tile.ui b/src/gs-popular-tile.ui
index d52da2f2..dd51b82b 100644
--- a/src/gs-popular-tile.ui
+++ b/src/gs-popular-tile.ui
@@ -33,6 +33,7 @@
             <property name="valign">fill</property>
             <child type="overlay">
               <object class="GtkEventBox" id="eventbox">
+                <property name="visible">False</property>
                 <property name="no_show_all">True</property>
                 <property name="visible_window">True</property>
                 <property name="halign">end</property>
diff --git a/src/gs-summary-tile.ui b/src/gs-summary-tile.ui
index 4cab0961..2c6fe9b7 100644
--- a/src/gs-summary-tile.ui
+++ b/src/gs-summary-tile.ui
@@ -36,6 +36,7 @@
             <property name="valign">fill</property>
             <child type="overlay">
               <object class="GtkEventBox" id="eventbox">
+                <property name="visible">False</property>
                 <property name="no_show_all">True</property>
                 <property name="visible_window">True</property>
                 <property name="halign">end</property>
diff --git a/src/gs-updates-page.ui b/src/gs-updates-page.ui
index a2545ace..89f69662 100644
--- a/src/gs-updates-page.ui
+++ b/src/gs-updates-page.ui
@@ -13,6 +13,7 @@
         <property name="orientation">vertical</property>
         <child>
           <object class="GtkBox" id="box_end_of_life">
+            <property name="visible">False</property>
             <property name="can_focus">False</property>
             <property name="border_width">0</property>
             <property name="orientation">horizontal</property>
[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]