[gnome-software] ubuntu-reviews: Retire Ubuntu Reviews plugin
- From: Robert Ancell <rancell src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] ubuntu-reviews: Retire Ubuntu Reviews plugin
- Date: Fri, 30 Nov 2018 10:14:09 +0000 (UTC)
commit 952eed2cff29f80a5248fb8d953dec6954cd4e38
Author: Robert Ancell <robert ancell canonical com>
Date: Wed Nov 28 09:14:20 2018 +1300
ubuntu-reviews: Retire Ubuntu Reviews plugin
This service has been retired and Ubuntu now used ODRS.
contrib/gnome-software.spec.in | 3 +-
doc/api/gnome-software-docs.xml | 4 +-
meson.build | 5 -
meson_options.txt | 1 -
plugins/meson.build | 3 -
plugins/snap/gs-plugin-snap.c | 1 -
plugins/ubuntu-reviews/gs-plugin-ubuntu-reviews.c | 992 ----------------------
plugins/ubuntu-reviews/meson.build | 14 -
8 files changed, 3 insertions(+), 1020 deletions(-)
---
diff --git a/contrib/gnome-software.spec.in b/contrib/gnome-software.spec.in
index b91339ea..c4d5c5f3 100644
--- a/contrib/gnome-software.spec.in
+++ b/contrib/gnome-software.spec.in
@@ -118,8 +118,7 @@ Adds support for Snap packages from the Snap store.
-Dexternal_appstream=false \
-Drpm_ostree=true \
-Dtests=false \
- -Dubuntuone=false \
- -Dubuntu_reviews=false
+ -Dubuntuone=false
%meson_build
%install
diff --git a/doc/api/gnome-software-docs.xml b/doc/api/gnome-software-docs.xml
index b0847097..cce7512a 100644
--- a/doc/api/gnome-software-docs.xml
+++ b/doc/api/gnome-software-docs.xml
@@ -140,8 +140,8 @@ gcc -shared -o libgs_plugin_example.so gs-plugin-example.c -fPIC \
<title>Distribution Specific Functionality</title>
<para>
Some plugins should only run on specific distributions, for instance
- the <code>ubuntu-reviews</code> plugin should only be used on Ubuntu
- systems.
+ the <code>fedora-pkgdb-collections</code> plugin should only be used on
+ Fedora systems.
This can be achieved with a simple runtime check using the helper
<code>gs_plugin_check_distro_id()</code> method or the <code>GsOsRelease</code>
object where more complicated rules are required.
diff --git a/meson.build b/meson.build
index f435ad79..ef349e67 100644
--- a/meson.build
+++ b/meson.build
@@ -162,11 +162,6 @@ if get_option('rpm_ostree')
rpm_ostree = dependency('rpm-ostree-1', version : '>= 2018.4')
endif
-if get_option('ubuntu_reviews')
- oauth = dependency('oauth')
- sqlite3 = dependency('sqlite3')
-endif
-
if get_option('gudev')
gudev = dependency('gudev-1.0')
endif
diff --git a/meson_options.txt b/meson_options.txt
index 9d821bc1..52c0b33b 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -11,7 +11,6 @@ option('rpm_ostree', type : 'boolean', value : false, description : 'enable rpm-
option('shell_extensions', type : 'boolean', value : true, description : 'enable shell extensions support')
option('odrs', type : 'boolean', value : true, description : 'enable ODRS support')
option('ubuntuone', type : 'boolean', value : true, description : 'enable UbuntuOne support')
-option('ubuntu_reviews', type : 'boolean', value : true, description : 'enable Ubuntu reviews support')
option('webapps', type : 'boolean', value : true, description : 'enable webapps support')
option('gudev', type : 'boolean', value : true, description : 'enable GUdev support')
option('snap', type : 'boolean', value : false, description : 'enable Snap support')
diff --git a/plugins/meson.build b/plugins/meson.build
index 7b934302..79d4ca4c 100644
--- a/plugins/meson.build
+++ b/plugins/meson.build
@@ -41,9 +41,6 @@ endif
if get_option('ubuntuone')
subdir('ubuntuone')
endif
-if get_option('ubuntu_reviews')
- subdir('ubuntu-reviews')
-endif
if get_option('external_appstream')
subdir('external-appstream')
endif
diff --git a/plugins/snap/gs-plugin-snap.c b/plugins/snap/gs-plugin-snap.c
index 739fbe4d..15d80924 100644
--- a/plugins/snap/gs-plugin-snap.c
+++ b/plugins/snap/gs-plugin-snap.c
@@ -78,7 +78,6 @@ gs_plugin_initialize (GsPlugin *plugin)
gs_plugin_add_auth (plugin, priv->auth);
gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_AFTER, "desktop-categories");
- gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_AFTER, "ubuntu-reviews");
gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_BETTER_THAN, "packagekit");
gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_BEFORE, "icons");
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]