[gnome-software/gnome-3-30] When adding queued GApplication actions, don't clear the loading state



commit d79bd0cf440bcbc062c711284ea42008945b6b42
Author: Robert McQueen <rob endlessm com>
Date:   Wed Oct 10 15:32:19 2018 +0100

    When adding queued GApplication actions, don't clear the loading state
    
    It's possible (although arguably, undesirable) for more than one GAction to be
    queued up before the shell has finished loading, so there is no reason to
    disconnect this callback when adding a deferred action. Leave it in place so
    GsApplication has one place to check whether the shell has finished the initial
    refresh or not.

 src/gs-application.c | 3 ---
 1 file changed, 3 deletions(-)
---
diff --git a/src/gs-application.c b/src/gs-application.c
index 8557e1ff..572e4746 100644
--- a/src/gs-application.c
+++ b/src/gs-application.c
@@ -868,9 +868,6 @@ wrapper_action_activated_cb (GSimpleAction *action,
                                                                       G_SIMPLE_ACTION (real_action),
                                                                       g_variant_ref (parameter));
 
-               g_signal_handler_disconnect (app->shell, app->shell_loaded_handler_id);
-               app->shell_loaded_handler_id = 0;
-
                g_signal_connect_swapped (app->shell, "loaded",
                                          G_CALLBACK (activate_on_shell_loaded_cb), helper);
                return;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]