[nautilus/antoniof/zero_press_event] list-view: Make clicking on star work again



commit eb34725034d55b9bf3bc4abd4da3057bd0c0e953
Author: António Fernandes <antoniof gnome org>
Date:   Thu Nov 22 11:33:38 2018 +0000

    list-view: Make clicking on star work again
    
    Clicking on the star icon would toggle the starred status in ver. 3.28
    This regressed in commit 3a7ebc2b769fa60ade93cb7ffa3419012c12f3ba
    
    The old code logic reset the click_count to 0 when it was actually 1.
    n_press resets to 1 so this broke the " <= 0 " condition.
    
    Anyway, we don't need to look at n_press because it is implicit in the
    is_simple_click boolean.
    
    Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/761

 src/nautilus-list-view.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/nautilus-list-view.c b/src/nautilus-list-view.c
index b118c785a..9ea98383d 100644
--- a/src/nautilus-list-view.c
+++ b/src/nautilus-list-view.c
@@ -652,7 +652,7 @@ on_tree_view_multi_press_gesture_pressed (GtkGestureMultiPress *gesture,
                                                NULL,
                                                NULL));
 
-    if (is_simple_click && n_press <= 0 && on_star)
+    if (is_simple_click && on_star)
     {
         on_star_cell_renderer_clicked (path, view);
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]