[geary/wip/improve-claiming-folder-session: 4/9] Don't actually execue remote ReplayQueue.CloseReplayQueue operation



commit ecda651574f6c691e2baf909cdb7ca0ca8dffeaa
Author: Michael Gratton <mike vee net>
Date:   Sun Nov 11 08:13:07 2018 +1100

    Don't actually execue remote ReplayQueue.CloseReplayQueue operation
    
    We don't have a valid remote folder session for it, so don't try to
    pretend we do.

 src/engine/imap-engine/imap-engine-replay-queue.vala | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/engine/imap-engine/imap-engine-replay-queue.vala 
b/src/engine/imap-engine/imap-engine-replay-queue.vala
index b565971d..7238ffa0 100644
--- a/src/engine/imap-engine/imap-engine-replay-queue.vala
+++ b/src/engine/imap-engine/imap-engine-replay-queue.vala
@@ -38,6 +38,8 @@ private class Geary.ImapEngine.ReplayQueue : Geary.BaseObject {
             return Status.CONTINUE;
         }
 
+        // This doesn't actually get executed, but it's here for
+        // completeness
         public override async void replay_remote_async(Imap.FolderSession remote)
             throws GLib.Error {
             this.remote_closed = true;
@@ -506,9 +508,9 @@ private class Geary.ImapEngine.ReplayQueue : Geary.BaseObject {
             }
             
             remotely_executing(op);
-            
+
             Error? remote_err = null;
-            if (folder_opened || is_close_op) {
+            if (remote != null) {
                 if (op.remote_retry_count > 0)
                     debug("Retrying op %s on %s", op.to_string(), to_string());
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]