[vte/wip/egmont/bidi: 67/73] fix crash when selecting autoscrolls



commit 7b48c03648d1945a4b29feaa4779661c72d3537e
Author: Egmont Koblinger <egmont gmail com>
Date:   Wed Sep 19 14:02:50 2018 +0200

    fix crash when selecting autoscrolls

 BIDI-STATUS | 1 -
 src/vte.cc  | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
---
diff --git a/BIDI-STATUS b/BIDI-STATUS
index 4d0f734d..b2915df5 100644
--- a/BIDI-STATUS
+++ b/BIDI-STATUS
@@ -19,7 +19,6 @@ Bugs:
   is split or two paragraphs are joined is just a first hack, needs to be
   reviewed, adjusted, fixed properly.
 - Copying text in rectangle mode.
-- Crashes when mouse selection initiates scrolling.
 
 Missing from first release:
 - Adjust mouse reporting.
diff --git a/src/vte.cc b/src/vte.cc
index f2450df9..37ec19ce 100644
--- a/src/vte.cc
+++ b/src/vte.cc
@@ -1611,7 +1611,7 @@ Terminal::selection_grid_halfcoords_from_view_coords(vte::view::coords const& po
 
         if (!m_selection_block_mode) {
                 /* BiDi: convert from visual to logical half column. */
-                vte::base::BidiRow const* bidirow = m_ringview.get_row_map(row);
+                vte::base::BidiRow const* bidirow = m_ringview.get_row_map(confine_grid_row(row));
 
                 if (bidirow->vis_is_rtl(col))
                         half = 1 - half;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]