[tracker/wip/carlosg/sparql-parser-ng: 4/6] libtracker-data: Make unimplemented property path errors more specific



commit 3c88a7460d5e44a088ac3645ac75f6cb281f40b5
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sat Nov 3 13:19:02 2018 +0100

    libtracker-data: Make unimplemented property path errors more specific
    
    There's now partial support of property paths, so better be specific.

 src/libtracker-data/tracker-sparql.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/src/libtracker-data/tracker-sparql.c b/src/libtracker-data/tracker-sparql.c
index 9a2732a80..1ff98e0f7 100644
--- a/src/libtracker-data/tracker-sparql.c
+++ b/src/libtracker-data/tracker-sparql.c
@@ -4068,7 +4068,7 @@ translate_PathAlternative (TrackerSparql  *sparql,
        _call_rule (sparql, NAMED_RULE_PathSequence, error);
 
        if (_accept (sparql, RULE_TYPE_LITERAL, LITERAL_PATH_ALTERNATIVE)) {
-               _unimplemented ("Property paths");
+               _unimplemented ("Alternative property path");
        }
 
        return TRUE;
@@ -4170,7 +4170,7 @@ translate_PathMod (TrackerSparql  *sparql,
 {
        /* PathMod ::= '?' | '*' | '+'
         */
-       _unimplemented ("Property paths");
+       _unimplemented ("Path modifiers");
 }
 
 static gboolean
@@ -4202,7 +4202,8 @@ translate_PathNegatedPropertySet (TrackerSparql  *sparql,
 {
        /* PathNegatedPropertySet ::= PathOneInPropertySet | '(' ( PathOneInPropertySet ( '|' 
PathOneInPropertySet )* )? ')'
         */
-       _unimplemented ("Property paths");
+       _unimplemented ("Negated property set in property paths");
+       return FALSE;
 }
 
 static gboolean
@@ -4211,7 +4212,7 @@ translate_PathOneInPropertySet (TrackerSparql  *sparql,
 {
        /* PathOneInPropertySet ::= iri | 'a' | '^' ( iri | 'a' )
         */
-       _unimplemented ("Property paths");
+       return FALSE;
 }
 
 static gboolean


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]