[gnome-builder/wip/chergert/completion] completion: clear old state



commit b349dbd7c98e281a08449c37d6281dd7a83a6526
Author: Christian Hergert <chergert redhat com>
Date:   Wed May 30 19:56:01 2018 -0700

    completion: clear old state
    
    This improves our sizing requests when rows are hidden.

 src/libide/completion/ide-completion-list-box-row.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
---
diff --git a/src/libide/completion/ide-completion-list-box-row.c 
b/src/libide/completion/ide-completion-list-box-row.c
index 16c5cc986..0531cfd27 100644
--- a/src/libide/completion/ide-completion-list-box-row.c
+++ b/src/libide/completion/ide-completion-list-box-row.c
@@ -177,7 +177,16 @@ ide_completion_list_box_row_set_proposal (IdeCompletionListBoxRow *self,
   g_return_if_fail (!proposal || IDE_IS_COMPLETION_PROPOSAL (proposal));
 
   if (g_set_object (&self->proposal, proposal))
-    g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_PROPOSAL]);
+    {
+      if (proposal == NULL)
+        {
+          gtk_label_set_label (self->left, NULL);
+          gtk_label_set_label (self->center, NULL);
+          gtk_label_set_label (self->right, NULL);
+        }
+
+      g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_PROPOSAL]);
+    }
 }
 
 void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]