[gnome-builder/wip/chergert/completion] completion: handle selection out of bounds



commit 037769bd1860ecda26bda3c4414ebb3ff880cf53
Author: Christian Hergert <chergert redhat com>
Date:   Wed May 30 10:16:04 2018 -0700

    completion: handle selection out of bounds
    
    We handle this elsewhere, so we need this here too so we are consistent.

 src/libide/completion/ide-completion-list-box.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/libide/completion/ide-completion-list-box.c b/src/libide/completion/ide-completion-list-box.c
index cc1c1926d..05d01b3ba 100644
--- a/src/libide/completion/ide-completion-list-box.c
+++ b/src/libide/completion/ide-completion-list-box.c
@@ -697,9 +697,10 @@ ide_completion_list_box_get_selected (IdeCompletionListBox   *self,
     {
       guint n_items = g_list_model_get_n_items (G_LIST_MODEL (self->context));
 
-      if (self->selected < n_items)
+      if (n_items > 0)
         {
-          ide_completion_context_get_item_full (self->context, self->selected, provider, proposal);
+          guint selected = MIN (self->selected, n_items - 1);
+          ide_completion_context_get_item_full (self->context, selected, provider, proposal);
           return TRUE;
         }
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]