[balsa/wip/gtk4: 155/351] Do not leak new_item



commit 5395172450aeb8bbc66fab29ec75086d89dff530
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Thu Feb 8 14:10:49 2018 -0500

    Do not leak new_item

 src/filter-edit-callbacks.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/src/filter-edit-callbacks.c b/src/filter-edit-callbacks.c
index 461eecf..d47e5c0 100644
--- a/src/filter-edit-callbacks.c
+++ b/src/filter-edit-callbacks.c
@@ -1719,6 +1719,7 @@ fe_new_pressed(GtkWidget * widget, gpointer data)
 
     if (filter_errno!=FILTER_NOERR) {
         filter_perror(filter_strerror(filter_errno));
+        g_free(new_item);
         return;
     }
 
@@ -1737,7 +1738,8 @@ fe_new_pressed(GtkWidget * widget, gpointer data)
     gtk_tree_selection_select_iter(selection, &iter);
 
     /* Adds "New Filter" to the list of actual new filters names */
-    new_filters_names=g_list_prepend(new_filters_names,g_strdup(new_item));
+    /* new_filters_names takes ownership of new_item */
+    new_filters_names=g_list_prepend(new_filters_names, new_item);
     gtk_widget_grab_focus(fe_name_entry);
 }                       /* end fe_new_pressed() */
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]