[balsa/wip/gtk4: 148/351] Fix a use-after-free bug



commit 2998d9c99b325927b640f0a160b9832f810dfaf4
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Wed Feb 7 14:28:19 2018 -0500

    Fix a use-after-free bug
    
    * src/sendmsg-window.c (edit_with_gnome_check): unlink the file
      before freeing its name.

 ChangeLog            |    7 +++++++
 src/sendmsg-window.c |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 0abaa35..0756954 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2018-02-07  Peter Bloomfield  <pbloomfield bellsouth net>
+
+       Fix a use-after-free bug
+
+       * src/sendmsg-window.c (edit_with_gnome_check): unlink the file
+       before freeing its name.
+
 2018-01-26  Peter Bloomfield  <pbloomfield bellsouth net>
 
        * meson.build: use Unicode quotation marks.
diff --git a/src/sendmsg-window.c b/src/sendmsg-window.c
index 9108c6d..1dfcbce 100644
--- a/src/sendmsg-window.c
+++ b/src/sendmsg-window.c
@@ -760,9 +760,9 @@ edit_with_gnome_check(gpointer data) {
         gtk_text_buffer_insert_at_cursor(buffer, line, -1);
     sw_buffer_signals_unblock(data_real->bsmsg, buffer);
 
-    g_free(data_real->filename);
     fclose(tmp);
     unlink(data_real->filename);
+    g_free(data_real->filename);
     gtk_widget_set_sensitive(data_real->bsmsg->text, TRUE);
     g_free(data);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]