[balsa/wip/gmime3: 169/197] Fix two use-after-free false positives



commit 81b715ef5181fbe97f02a10064484783c8a4775c
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Wed Feb 7 14:38:13 2018 -0500

    Fix two use-after-free false positives
    
    * src/filter-edit-callbacks.c (change_filter_name): Use
      g_list_delete_link() with a valid link instead of
      g_list_remove() with the address of freed data.

 ChangeLog                   |    8 ++++++++
 src/filter-edit-callbacks.c |    4 ++--
 2 files changed, 10 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 5032edd..403acd5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2018-02-07  Peter Bloomfield  <pbloomfield bellsouth net>
 
+       Fix two use-after-free false positives
+
+       * src/filter-edit-callbacks.c (change_filter_name): Use
+       g_list_delete_link() with a valid link instead of
+       g_list_remove() with the address of freed data.
+
+2018-02-07  Peter Bloomfield  <pbloomfield bellsouth net>
+
        Fix a use-after-free bug
 
        * src/sendmsg-window.c (edit_with_gnome_check): unlink the file
diff --git a/src/filter-edit-callbacks.c b/src/filter-edit-callbacks.c
index e6162c8..f9c239b 100644
--- a/src/filter-edit-callbacks.c
+++ b/src/filter-edit-callbacks.c
@@ -1664,7 +1664,7 @@ change_filter_name(gchar * old_name,gchar * new_name)
             if (new_name)
                 lst->data=g_strdup(new_name);
             else
-                new_filters_names=g_list_remove(new_filters_names,lst->data);
+                new_filters_names=g_list_delete_link(new_filters_names,lst);
             return;
         }
        
@@ -1692,7 +1692,7 @@ change_filter_name(gchar * old_name,gchar * new_name)
            g_free(p->old_name);
            g_free(p);
             filters_names_changes=
-                g_list_remove(filters_names_changes,lst->data);
+                g_list_delete_link(filters_names_changes,lst);
             return;
         }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]