[gimp/gtk3-port] app: GTK+3 has more GdkAxisUse values.



commit 2f805dfefb30f3f33effeea998a8683868df7f77
Author: Jehan <jehan girinstud io>
Date:   Mon May 14 03:09:37 2018 +0200

    app: GTK+3 has more GdkAxisUse values.
    
    This fixes a crash when we were looping until GDK_AXIS_LAST, but our
    existing code was expecting less values.
    
    Also I note that GTK+3 has an additional GDK_AXIS_ROTATION since version
    3.22, even though we were told that some pens with rotation support
    would report rotation values with same valuator as for the wheel (at
    least, the Wacom Art Pen would apparently use the same 6th valuator).
    For proper support, it would be really worth testing such pens.

 app/widgets/gimpdeviceinfoeditor.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/app/widgets/gimpdeviceinfoeditor.c b/app/widgets/gimpdeviceinfoeditor.c
index b6b07e8..943dfc9 100644
--- a/app/widgets/gimpdeviceinfoeditor.c
+++ b/app/widgets/gimpdeviceinfoeditor.c
@@ -142,10 +142,16 @@ static const gchar *const axis_use_strings[] =
   N_("X tilt"),
   N_("Y tilt"),
   /* Wheel as in mouse or input device wheel.
-   * Some pens use the same axis for their rotation feature.
+   * Some pens would use the same axis for their rotation feature.
    * See bug 791455.
+   * Yet GTK+ has a different axis since v. 3.22.
+   * TODO: this should be actually tested with a device having such
+   * feature.
    */
-  N_("Wheel/Rotation")
+  N_("Wheel"),
+  N_("Distance"),
+  N_("Rotation"),
+  N_("Slider")
 };
 
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]