[gimp] Bug 795855 - File chooser dialogs do not show folders or files for...



commit 8d7f13be186401c4d5c63e6e666b9105ac968dfe
Author: Jehan <jehan girinstud io>
Date:   Sat May 12 23:00:22 2018 +0200

    Bug 795855 - File chooser dialogs do not show folders or files for...
    
    ... drive roots (e.g. C:\, D:\, ...))
    
    This is a regression of glib 2.56 (not applying to 2.54 since it is new
    code). It has been fixed recently in what will be 2.56.2 but is not
    released yet, so we can't just bump the requirement.
    
    Since it is a pretty bad bug though, let's add a test specifically for
    these versions in the configure script so that nobody will package these
    versions of glib. We can remove this test when we will bump the glib
    requirement.

 configure.ac |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index 38b0dab..bfc9be5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -685,7 +685,15 @@ PKG_CHECK_MODULES(GEGL, gegl-gegl_major_minor_version >= gegl_required_version,,
 PKG_CHECK_MODULES(ATK, atk >= atk_required_version,,
                   [add_deps_error([atk >= atk_required_version])])
 
-AM_PATH_GLIB_2_0(glib_required_version, :,
+# glib 2.56.0 and 2.56.1 have a bad bug on Win32, breaking the file
+# chooser dialogs. This has been fixed, but no release made yet. When
+# 2.56.2 is released, the additional test for these broken versions can
+# be removed and we can bump the requirement to glib 2.56.2.
+AM_PATH_GLIB_2_0(glib_required_version,
+                 [if test "x$platform_win32" = "xyes"; then
+                   PKG_CHECK_MODULES(GLIB_WIN_BUG, glib-2.0 >= 2.56.0 glib-2.0 < 2.56.2,
+                                     [add_deps_error([glib >= glib_required_version except glib 2.56.0 and 
2.56.1 (broken on Win32 - bug 795855)])],:)
+                 fi],
                  [add_deps_error([glib >= glib_required_version],
                                  [Test for GLIB failed])],
                  gobject)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]