[glade/wip/dboles/template-version-warning: 6/6] ui/widget: Make template ver# warning more useful



commit 1149c7cebac5327a6634fe1a347115af16b57bf3
Author: Daniel Boles <dboles src gmail com>
Date:   Wed Apr 4 00:14:04 2018 +0100

    ui/widget: Make template ver# warning more useful
    
    Composite widget templates are only supported by GTK+ 3.10 and up, but
    if a user targeted a lower version, we only told them that said version
    did not support templates, but provided no help on how to resolve that.
    
    A user in #gtk+ mistook that vague warning as meaning widget templates
    had been deprecated in their (then) target version, GTK+ 3.0. Whoops!
    
    It makes more sense to tell users what version they need, which is new
    info, instead of what they are currently targeting, which they know.

 gladeui/glade-widget.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
---
diff --git a/gladeui/glade-widget.c b/gladeui/glade-widget.c
index e2b38744..960e3fd2 100644
--- a/gladeui/glade-widget.c
+++ b/gladeui/glade-widget.c
@@ -4800,8 +4800,7 @@ glade_widget_verify (GladeWidget *widget)
       glade_project_get_target_version (priv->project, "gtk+", &major, &minor);
 
       if (major == 3 && minor < 10)
-        warning = g_strdup_printf (_("Template classes are not supported in gtk+ %d.%d"),
-                                   major, minor); 
+        warning = g_strdup (_("Template classes are only usable in GTK+ 3.10 and later."));
     }
 
   if (!warning && GLADE_IS_OBJECT_STUB (priv->object))


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]