[gnumeric] Plug leaks.



commit 164412775cadd4ad68effe7a4a47021d9a0d16ab
Author: Morten Welinder <terra gnome org>
Date:   Mon May 7 21:19:02 2018 -0400

    Plug leaks.

 ChangeLog      |    4 ++++
 NEWS           |    3 +++
 src/gnm-pane.c |   17 +++++++----------
 3 files changed, 14 insertions(+), 10 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index feebe29..7195e97 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2018-05-07  Morten Welinder  <terra gnome org>
+
+       * src/gnm-pane.c (gnm_pane_key_mode_sheet): Plug leaks.
+
 2018-05-07  Morten Welinder <terra gnome org>
 
        * configure.ac: Post-release bump.
diff --git a/NEWS b/NEWS
index 23aa359..b794986 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
 Gnumeric 1.12.42
 
+Morten:
+       * Plug leaks.
+
 --------------------------------------------------------------------------
 Gnumeric 1.12.41
 
diff --git a/src/gnm-pane.c b/src/gnm-pane.c
index db731a9..18e7f91 100644
--- a/src/gnm-pane.c
+++ b/src/gnm-pane.c
@@ -271,11 +271,10 @@ gnm_pane_key_mode_sheet (GnmPane *pane, GdkEventKey *kevent,
        case GDK_KEY_Page_Up:
                if (event_state & GDK_CONTROL_MASK) {
                        if (event_state & GDK_SHIFT_MASK) {
-                               WorkbookSheetState * old_state = workbook_sheet_state_new(wb);
                                int old_pos = sheet->index_in_wb;
-
-                               if (old_pos > 0){
-                                       workbook_sheet_move(sheet, -1);
+                               if (old_pos > 0) {
+                                       WorkbookSheetState * old_state = workbook_sheet_state_new (wb);
+                                       workbook_sheet_move (sheet, -1);
                                        cmd_reorganize_sheets (wbc, old_state, sheet);
                                }
                        } else {
@@ -296,15 +295,13 @@ gnm_pane_key_mode_sheet (GnmPane *pane, GdkEventKey *kevent,
 
        case GDK_KEY_KP_Page_Down:
        case GDK_KEY_Page_Down:
-
                if ((event_state & GDK_CONTROL_MASK) != 0){
                        if ((event_state & GDK_SHIFT_MASK) != 0){
-                               WorkbookSheetState * old_state = workbook_sheet_state_new(wb);
-                               int num_sheets = workbook_sheet_count(wb);
+                               int num_sheets = workbook_sheet_count (wb);
                                gint old_pos = sheet->index_in_wb;
-
-                               if (old_pos < num_sheets - 1){
-                                       workbook_sheet_move(sheet, 1);
+                               if (old_pos < num_sheets - 1) {
+                                       WorkbookSheetState *old_state = workbook_sheet_state_new (wb);
+                                       workbook_sheet_move (sheet, 1);
                                        cmd_reorganize_sheets (wbc, old_state, sheet);
                                }
                        } else {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]