[devhelp] Settings: make ::books-disabled-changed a Run First signal



commit 09b07aadab9c7468bd0aafa8843f37c73a879616
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Tue May 1 12:08:34 2018 +0200

    Settings: make ::books-disabled-changed a Run First signal
    
    It was not useful to have it as a Run Last signal, and it needed more
    docs.

 devhelp/dh-book-list-simple.c |    2 +-
 devhelp/dh-settings.c         |    6 +-----
 src/dh-preferences.c          |    2 +-
 3 files changed, 3 insertions(+), 7 deletions(-)
---
diff --git a/devhelp/dh-book-list-simple.c b/devhelp/dh-book-list-simple.c
index 43706ae..fc15f36 100644
--- a/devhelp/dh-book-list-simple.c
+++ b/devhelp/dh-book-list-simple.c
@@ -224,7 +224,7 @@ _dh_book_list_simple_new (GList      *sub_book_lists,
                                          "books-disabled-changed",
                                          G_CALLBACK (books_disabled_changed_cb),
                                          list_simple,
-                                         G_CONNECT_AFTER);
+                                         0);
         }
 
         repopulate (list_simple);
diff --git a/devhelp/dh-settings.c b/devhelp/dh-settings.c
index 23916f9..af8ba5d 100644
--- a/devhelp/dh-settings.c
+++ b/devhelp/dh-settings.c
@@ -308,16 +308,12 @@ dh_settings_class_init (DhSettingsClass *klass)
          * The ::books-disabled-changed signal is emitted when the
          * "books-disabled" #GSettings key changes.
          *
-         * It is guaranteed that dh_settings_is_book_enabled() will return the
-         * new value only *after* the default object method handler for this
-         * signal has run (it's a %G_SIGNAL_RUN_LAST signal).
-         *
          * Since: 3.30
          */
         signals[SIGNAL_BOOKS_DISABLED_CHANGED] =
                 g_signal_new ("books-disabled-changed",
                               G_TYPE_FROM_CLASS (klass),
-                              G_SIGNAL_RUN_LAST,
+                              G_SIGNAL_RUN_FIRST,
                               G_STRUCT_OFFSET (DhSettingsClass, books_disabled_changed),
                               NULL, NULL, NULL,
                               G_TYPE_NONE, 0);
diff --git a/src/dh-preferences.c b/src/dh-preferences.c
index 8ea680a..648fc94 100644
--- a/src/dh-preferences.c
+++ b/src/dh-preferences.c
@@ -606,7 +606,7 @@ init_bookshelf_tab (DhPreferences *prefs)
                                  "books-disabled-changed",
                                  G_CALLBACK (bookshelf_books_disabled_changed_cb),
                                  prefs,
-                                 G_CONNECT_AFTER);
+                                 0);
 
         g_signal_connect_object (priv->full_book_list,
                                  "add-book",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]