[vte] emulation: Port DL, IL to new parameter glue



commit 33ce2d03b16b6a46c8cb1032864e7b4dc29db0f3
Author: Christian Persch <chpe src gnome org>
Date:   Tue Mar 27 19:40:12 2018 +0200

    emulation: Port DL, IL to new parameter glue

 src/vteseq-list.hh |    1 -
 src/vteseq.cc      |   28 ++++++++--------------------
 2 files changed, 8 insertions(+), 21 deletions(-)
---
diff --git a/src/vteseq-list.hh b/src/vteseq-list.hh
index a281a6b..70ddeb9 100644
--- a/src/vteseq-list.hh
+++ b/src/vteseq-list.hh
@@ -34,7 +34,6 @@ SEQUENCE_HANDLER(cursor_lower_left)
 SEQUENCE_HANDLER(dec_media_copy)
 SEQUENCE_HANDLER(decreset)
 SEQUENCE_HANDLER(decset)
-SEQUENCE_HANDLER(delete_lines)
 SEQUENCE_HANDLER(device_control_string)
 SEQUENCE_HANDLER(double_height_bottom_half)
 SEQUENCE_HANDLER(double_height_top_half)
diff --git a/src/vteseq.cc b/src/vteseq.cc
index 11b1ac8..92baab5 100644
--- a/src/vteseq.cc
+++ b/src/vteseq.cc
@@ -2053,15 +2053,6 @@ VteTerminalPrivate::seq_full_reset(vte::parser::Params const& params)
        reset(true, true);
 }
 
-/* Insert a certain number of lines below the current cursor. */
-void
-VteTerminalPrivate::seq_insert_lines(vte::parser::Params const& params)
-{
-       /* The default is one. */
-        auto param = params.number_or_default_at(0, 1);
-        insert_lines(param);
-}
-
 void
 VteTerminalPrivate::insert_lines(vte::grid::row_t param)
 {
@@ -2096,15 +2087,6 @@ VteTerminalPrivate::insert_lines(vte::grid::row_t param)
         m_text_inserted_flag = TRUE;
 }
 
-/* Delete certain lines from the scrolling region. */
-void
-VteTerminalPrivate::seq_delete_lines(vte::parser::Params const& params)
-{
-       /* The default is one. */
-        auto param = params.number_or_default_at(0, 1);
-        delete_lines(param);
-}
-
 void
 VteTerminalPrivate::delete_lines(vte::grid::row_t param)
 {
@@ -4267,6 +4249,8 @@ VteTerminalPrivate::DL(vte::parser::Sequence const& seq)
          *
          * Defaults:
          *   args[0]: 1
+         *
+         * References: ECMA-48 § 8.3.32
          */
 #if 0
         unsigned int num = 1;
@@ -4281,7 +4265,8 @@ VteTerminalPrivate::DL(vte::parser::Sequence const& seq)
                                  screen->age);
 #endif
 
-        seq_delete_lines(seq);
+        auto const count = seq.collect1(0, 1);
+        delete_lines(count);
 }
 
 void
@@ -4748,6 +4733,8 @@ VteTerminalPrivate::IL(vte::parser::Sequence const& seq)
          *
          * Defaults:
          *   args[0]: 1
+         *
+         * References: ECMA-48 § 8.3.67
          */
 #if 0
         unsigned int num = 1;
@@ -4763,7 +4750,8 @@ VteTerminalPrivate::IL(vte::parser::Sequence const& seq)
                                  screen->age);
 #endif
 
-        seq_insert_lines(seq);
+        auto const count = seq.collect1(0, 1);
+        insert_lines(count);
 }
 
 void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]