[gnome-builder] git: clone callback needs access to task data
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] git: clone callback needs access to task data
- Date: Mon, 26 Mar 2018 20:53:33 +0000 (UTC)
commit 5d78edf28f9b6a8523d423f349e75688956c54a4
Author: Christian Hergert <chergert redhat com>
Date: Mon Mar 26 13:52:41 2018 -0700
git: clone callback needs access to task data
We can't finalize the task_data immediately after propagate, because we
need it in the _finish() function to complete some work.
This is still safe to do because of the thread-design in IdeTask, where as
this was not guaranteed safe with GTask.
Fixes #441
src/plugins/git/ide-git-clone-widget.c | 1 +
1 file changed, 1 insertion(+)
---
diff --git a/src/plugins/git/ide-git-clone-widget.c b/src/plugins/git/ide-git-clone-widget.c
index 30963cdd6..ce53b8a79 100644
--- a/src/plugins/git/ide-git-clone-widget.c
+++ b/src/plugins/git/ide-git-clone-widget.c
@@ -456,6 +456,7 @@ ide_git_clone_widget_clone_async (IdeGitCloneWidget *self,
gtk_widget_show (GTK_WIDGET (self->clone_progress));
ide_task_set_task_data (task, req, clone_request_free);
+ ide_task_set_release_on_propagate (task, FALSE);
ide_task_run_in_thread (task, ide_git_clone_widget_worker);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]