[vala: 11/11] codegen: Deprecate implicit copy of arrays, use explicit copy method

[Rico Tzschichholz <ricotz src gnome org>]

commit ae4c2cbc3c51f2e98f62cc9b48e0d8a18bd47092
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Sun Sep 3 19:48:31 2017 +0200

    codegen: Deprecate implicit copy of arrays, use explicit copy method
    
    https://bugzilla.gnome.org/show_bug.cgi?id=650663

 codegen/valaccodebasemodule.vala |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
---
diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index 9f02b8c..3de9438 100644
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -5876,6 +5876,13 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
                                return result;
                        }
                        result = copy;
+
+                       // implicit array copying is deprecated, but allow it for internal codegen usage
+                       var prop_acc = node as PropertyAccessor;
+                       if ((prop_acc != null && !prop_acc.automatic_body)
+                           && result.value_type is ArrayType) {
+                               Report.deprecated (node.source_reference, "implicit copy of array is 
deprecated, explicitly invoke the copy method instead");
+                       }
                }
 
                return result;