[gtk] FileChooserWidget: Avoid crash freeing static str

[Daniel Boles <dboles src gnome org>]

commit fc9dc97430ec276dfb804059fe74d1ea3d899455
Author: Daniel Boles <dboles src gnome org>
Date:   Mon Mar 12 22:44:37 2018 +0000

    FileChooserWidget: Avoid crash freeing static str
    
    Having a FileChooserDialog in location-entry mode then pressing
    <primary>f to move to search mode would crash with an invalid free().
    
    In that case, FileChooserWidget.get_subtitle() returned a static string
    straight from gettext. This crashed when the GBinding from :subtitle to
    FileChooserDialog’s HeaderBar:subtitle shortly tried to free the string.
    
    Fix by duplicating the string before returning it, like all other paths.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=791004

 gtk/gtkfilechooserwidget.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gtk/gtkfilechooserwidget.c b/gtk/gtkfilechooserwidget.c
index 0d6132c020..e94de516bd 100644
--- a/gtk/gtkfilechooserwidget.c
+++ b/gtk/gtkfilechooserwidget.c
@@ -3198,7 +3198,7 @@ gtk_file_chooser_widget_get_subtitle (GtkFileChooserWidget *impl)
     {
       gchar *location;
 
-      subtitle = _("Searching");
+      subtitle = g_strdup (_("Searching"));
 
       location = gtk_places_sidebar_get_location_title (GTK_PLACES_SIDEBAR (priv->places_sidebar));
       if (location)