[seahorse] Ssh: use "key length" instead of strength.
- From: Niels De Graef <nielsdg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [seahorse] Ssh: use "key length" instead of strength.
- Date: Thu, 8 Mar 2018 21:30:07 +0000 (UTC)
commit 16954528dcc88cde791c05246bc45776c313bfb7
Author: Niels De Graef <nielsdegraef gmail com>
Date: Thu Mar 8 07:43:21 2018 +0100
Ssh: use "key length" instead of strength.
Although a larger key length can lead to a notion of comparable strength
within a certain algorithm (e.g. a 2048-bit RSA key is stronger than a
1024-bit one), this does not extrapolate to other keys. To make a very
basic example: a 521-bit ECDSA key is not "half as weak" as a 1024 bit
RSA key.
ssh/key-properties.vala | 6 +++---
ssh/seahorse-ssh-key-properties.ui | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/ssh/key-properties.vala b/ssh/key-properties.vala
index 1a9b92e..687775d 100644
--- a/ssh/key-properties.vala
+++ b/ssh/key-properties.vala
@@ -38,7 +38,7 @@ public class Seahorse.Ssh.KeyProperties : Gtk.Dialog {
private Gtk.Label fingerprint_label;
private Gtk.Label algo_label;
private Gtk.Label location_label;
- private Gtk.Label strength_label;
+ private Gtk.Label key_length_label;
public KeyProperties(Key key, Gtk.Window parent) {
GLib.Object(border_width: 5,
@@ -81,7 +81,7 @@ public class Seahorse.Ssh.KeyProperties : Gtk.Dialog {
this.fingerprint_label = (Gtk.Label) builder.get_object("fingerprint-label");
this.algo_label = (Gtk.Label) builder.get_object("algo-label");
this.location_label = (Gtk.Label) builder.get_object("location-label");
- this.strength_label = (Gtk.Label) builder.get_object("strength-label");
+ this.key_length_label = (Gtk.Label) builder.get_object("key-length-label");
// Signals
this.comment_entry.activate.connect(on_ssh_comment_activate);
@@ -111,7 +111,7 @@ public class Seahorse.Ssh.KeyProperties : Gtk.Dialog {
this.fingerprint_label.label = this.key.fingerprint;
this.algo_label.label = this.key.get_algo().to_string() ?? _("Unknown type");
this.location_label.label = this.key.get_location();
- this.strength_label.label = "%u".printf(this.key.get_strength());
+ this.key_length_label.label = "%u".printf(this.key.get_strength());
this.updating_ui = false;
}
diff --git a/ssh/seahorse-ssh-key-properties.ui b/ssh/seahorse-ssh-key-properties.ui
index 933f181..b19b644 100644
--- a/ssh/seahorse-ssh-key-properties.ui
+++ b/ssh/seahorse-ssh-key-properties.ui
@@ -336,7 +336,7 @@
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="yalign">0</property>
- <property name="label" translatable="yes">Strength:</property>
+ <property name="label" translatable="yes">Key length:</property>
<attributes>
<attribute name="weight" value="bold"/>
</attributes>
@@ -364,7 +364,7 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="strength-label">
+ <object class="GtkLabel" id="key-length-label">
<property name="visible">True</property>
<property name="can_focus">True</property>
<property name="xalign">0</property>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]