[gnome-builder] device: remove IdeDevice:system-type
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] device: remove IdeDevice:system-type
- Date: Mon, 5 Mar 2018 05:57:08 +0000 (UTC)
commit 50c28cbc7efaf4112c5bde1d10b7d0e344009609
Author: Christian Hergert <chergert redhat com>
Date: Sun Mar 4 21:50:45 2018 -0800
device: remove IdeDevice:system-type
We need to get this info asynchronously through the get_info
API now instead.
src/libide/devices/ide-device.c | 39 -------------------------------------
src/libide/devices/ide-device.h | 3 ---
src/libide/local/ide-local-device.c | 13 -------------
3 files changed, 55 deletions(-)
---
diff --git a/src/libide/devices/ide-device.c b/src/libide/devices/ide-device.c
index ad7960edb..ebccef490 100644
--- a/src/libide/devices/ide-device.c
+++ b/src/libide/devices/ide-device.c
@@ -39,7 +39,6 @@ enum {
PROP_DISPLAY_NAME,
PROP_ICON_NAME,
PROP_ID,
- PROP_SYSTEM_TYPE,
N_PROPS
};
@@ -163,33 +162,6 @@ ide_device_set_id (IdeDevice *device,
}
}
-/**
- * ide_device_get_system_type:
- *
- * This is the description of the system we are building for. Commonly, this
- * is referred to as a "system_type". A combination of the machine architecture
- * such as x86_64, the operating system, and the libc.
- *
- * "x86_64-linux-gnu" might be one such system.
- *
- * Returns: A string containing the system type.
- */
-const gchar *
-ide_device_get_system_type (IdeDevice *device)
-{
- IdeDeviceClass *klass;
- const gchar *ret = NULL;
-
- g_return_val_if_fail (IDE_IS_DEVICE (device), NULL);
-
- klass = IDE_DEVICE_GET_CLASS (device);
-
- if (klass->get_system_type)
- ret = klass->get_system_type (device);
-
- return ret;
-}
-
static void
ide_device_real_get_info_async (IdeDevice *self,
GCancellable *cancellable,
@@ -246,10 +218,6 @@ ide_device_get_property (GObject *object,
g_value_set_string (value, ide_device_get_id (self));
break;
- case PROP_SYSTEM_TYPE:
- g_value_set_string (value, ide_device_get_system_type (self));
- break;
-
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
}
@@ -323,13 +291,6 @@ ide_device_class_init (IdeDeviceClass *klass)
NULL,
(G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
- properties [PROP_SYSTEM_TYPE] =
- g_param_spec_string ("system-type",
- "System Type",
- "The system type for which to compile.",
- NULL,
- (G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
-
g_object_class_install_properties (object_class, N_PROPS, properties);
}
diff --git a/src/libide/devices/ide-device.h b/src/libide/devices/ide-device.h
index 1e77cc4be..8aaa18fc9 100644
--- a/src/libide/devices/ide-device.h
+++ b/src/libide/devices/ide-device.h
@@ -40,7 +40,6 @@ struct _IdeDeviceClass
{
IdeObjectClass parent;
- const gchar *(*get_system_type) (IdeDevice *self);
void (*prepare_configuration) (IdeDevice *self,
IdeConfiguration *configuration);
void (*get_info_async) (IdeDevice *self,
@@ -72,8 +71,6 @@ IDE_AVAILABLE_IN_ALL
void ide_device_set_id (IdeDevice *self,
const gchar *id);
IDE_AVAILABLE_IN_ALL
-const gchar *ide_device_get_system_type (IdeDevice *self);
-IDE_AVAILABLE_IN_ALL
void ide_device_prepare_configuration (IdeDevice *self,
IdeConfiguration *configuration);
IDE_AVAILABLE_IN_3_28
diff --git a/src/libide/local/ide-local-device.c b/src/libide/local/ide-local-device.c
index 557659bae..8a73e74e0 100644
--- a/src/libide/local/ide-local-device.c
+++ b/src/libide/local/ide-local-device.c
@@ -45,18 +45,6 @@ enum {
static GParamSpec *properties [N_PROPS];
-static const gchar *
-ide_local_device_get_system_type (IdeDevice *device)
-{
- IdeLocalDevice *self = (IdeLocalDevice *)device;
- IdeLocalDevicePrivate *priv = ide_local_device_get_instance_private (self);
-
- g_return_val_if_fail (IDE_IS_LOCAL_DEVICE (device), NULL);
- g_return_val_if_fail (IDE_IS_LOCAL_DEVICE (self), NULL);
-
- return priv->system_type;
-}
-
static void
ide_local_device_get_info_async (IdeDevice *device,
GCancellable *cancellable,
@@ -245,7 +233,6 @@ ide_local_device_class_init (IdeLocalDeviceClass *klass)
object_class->get_property = ide_local_device_get_property;
object_class->set_property = ide_local_device_set_property;
- device_class->get_system_type = ide_local_device_get_system_type;
device_class->get_info_async = ide_local_device_get_info_async;
device_class->get_info_finish = ide_local_device_get_info_finish;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]