[gnome-shell/66-ghostly-close-buttons: 18/18] messageList: Fix invisible close buttons still working



commit 81dfcb85caeb9e9dd7d3d22c40e037f48844b9b7
Author: Florian Müllner <fmuellner gnome org>
Date:   Fri Feb 23 10:27:07 2018 +0100

    messageList: Fix invisible close buttons still working
    
    Since commit c4f2bb5f, close buttons are hidden by making them fully
    transparent rather than setting their visibility to false to keep
    the overall message layout stable. As a result, the buttons now work
    even when invisible, which is clearly unexpected - fix this by updating
    the reactive property appropriately.
    
    Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/66

 js/ui/messageList.js | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/js/ui/messageList.js b/js/ui/messageList.js
index 61987191b..aff201ed6 100644
--- a/js/ui/messageList.js
+++ b/js/ui/messageList.js
@@ -502,6 +502,7 @@ var Message = new Lang.Class({
     _sync() {
         let visible = this.actor.hover && this.canClose();
         this._closeButton.opacity = visible ? 255 : 0;
+        this._closeButton.reactive = visible;
     },
 
     _onClicked() {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]