GNOME.org
 

[nautilus/wip/ernestask/warnings: 8/14] general: fix old-style function declarations

commit 9e8f138999f880779474aecf156105e9758bc9e6
Author: Ernestas Kulik <ernestask gnome org>
Date:   Mon Feb 26 11:24:59 2018 +0200

    general: fix old-style function declarations
    
    Parameterless function declarations imply indeterminate parameter count,
    while the implementations take no arguments.

 extensions/sendto/nautilus-nste.c                  |  2 +-
 src/nautilus-debug.c                               |  2 +-
 src/nautilus-starred-directory.h                   |  2 +-
 src/nautilus-tag-manager.c                         |  3 +-
 src/nautilus-tag-manager.h                         |  2 +-
 src/nautilus-view-icon-controller.c                |  2 +-
 .../test-eel-string-get-common-prefix.c            | 20 +++++-----
 ...est-file-utilities-get-common-filename-prefix.c | 46 +++++++++++-----------
 8 files changed, 40 insertions(+), 39 deletions(-)
---
diff --git a/extensions/sendto/nautilus-nste.c b/extensions/sendto/nautilus-nste.c
index 3313d9a32..1e9280036 100644
--- a/extensions/sendto/nautilus-nste.c
+++ b/extensions/sendto/nautilus-nste.c
@@ -62,7 +62,7 @@ sendto_callback (NautilusMenuItem *item,
 }
 
 static gboolean
-check_available_mailer ()
+check_available_mailer (void)
 {
     g_autoptr (GAppInfo) app_info = NULL;
 
diff --git a/src/nautilus-debug.c b/src/nautilus-debug.c
index 972166fe8..e76a03f38 100644
--- a/src/nautilus-debug.c
+++ b/src/nautilus-debug.c
@@ -55,7 +55,7 @@ static GDebugKey keys[] =
 };
 
 static void
-nautilus_debug_set_flags_from_env ()
+nautilus_debug_set_flags_from_env (void)
 {
     guint nkeys;
     const gchar *flags_string;
diff --git a/src/nautilus-starred-directory.h b/src/nautilus-starred-directory.h
index 33bbff09c..e426aa74f 100644
--- a/src/nautilus-starred-directory.h
+++ b/src/nautilus-starred-directory.h
@@ -29,7 +29,7 @@ G_BEGIN_DECLS
 
 G_DECLARE_FINAL_TYPE (NautilusFavoriteDirectory, nautilus_starred_directory, NAUTILUS, STARRED_DIRECTORY, 
NautilusDirectory);
 
-NautilusFavoriteDirectory* nautilus_starred_directory_new      ();
+NautilusFavoriteDirectory* nautilus_starred_directory_new      (void);
 
 G_END_DECLS
 
diff --git a/src/nautilus-tag-manager.c b/src/nautilus-tag-manager.c
index 1b6be5eef..f6ecac652 100644
--- a/src/nautilus-tag-manager.c
+++ b/src/nautilus-tag-manager.c
@@ -841,7 +841,8 @@ nautilus_tag_manager_class_init (NautilusTagManagerClass *klass)
                                              G_TYPE_POINTER);
 }
 
-NautilusTagManager *nautilus_tag_manager_get ()
+NautilusTagManager *
+nautilus_tag_manager_get (void)
 {
     if (tag_manager != NULL)
     {
diff --git a/src/nautilus-tag-manager.h b/src/nautilus-tag-manager.h
index 89819cdb0..5cc36a4d9 100644
--- a/src/nautilus-tag-manager.h
+++ b/src/nautilus-tag-manager.h
@@ -29,7 +29,7 @@ G_BEGIN_DECLS
 
 G_DECLARE_FINAL_TYPE (NautilusTagManager, nautilus_tag_manager, NAUTILUS, TAG_MANAGER, GObject);
 
-NautilusTagManager* nautilus_tag_manager_get                ();
+NautilusTagManager* nautilus_tag_manager_get                (void);
 
 void                nautilus_tag_manager_set_cancellable    (NautilusTagManager *tag_manager,
                                                              GCancellable *cancellable);
diff --git a/src/nautilus-view-icon-controller.c b/src/nautilus-view-icon-controller.c
index 16bd4155c..a93717d1d 100644
--- a/src/nautilus-view-icon-controller.c
+++ b/src/nautilus-view-icon-controller.c
@@ -546,7 +546,7 @@ get_icon_size_for_zoom_level (NautilusCanvasZoomLevel zoom_level)
 }
 
 static gint
-get_default_zoom_level ()
+get_default_zoom_level (void)
 {
     NautilusCanvasZoomLevel default_zoom_level;
 
diff --git a/test/automated/displayless/test-eel-string-get-common-prefix.c 
b/test/automated/displayless/test-eel-string-get-common-prefix.c
index 2dc5d9e9a..6634c684c 100644
--- a/test/automated/displayless/test-eel-string-get-common-prefix.c
+++ b/test/automated/displayless/test-eel-string-get-common-prefix.c
@@ -13,7 +13,7 @@ free_list_and_result (GList *list,
 }
 
 static void
-test_has_large_enough_common_prefix ()
+test_has_large_enough_common_prefix (void)
 {
     GList *list = NULL;
     char *actual;
@@ -28,7 +28,7 @@ test_has_large_enough_common_prefix ()
 }
 
 static void
-test_has_common_prefix_that_equals_the_min_required_length ()
+test_has_common_prefix_that_equals_the_min_required_length (void)
 {
     GList *list = NULL;
     char *actual;
@@ -43,7 +43,7 @@ test_has_common_prefix_that_equals_the_min_required_length ()
 }
 
 static void
-test_has_common_prefix_that_equals_the_min_required_length2 ()
+test_has_common_prefix_that_equals_the_min_required_length2 (void)
 {
     GList *list = NULL;
     char *actual;
@@ -58,7 +58,7 @@ test_has_common_prefix_that_equals_the_min_required_length2 ()
 }
 
 static void
-test_many_strings_with_common_prefix ()
+test_many_strings_with_common_prefix (void)
 {
     GList *list = NULL;
     char *actual;
@@ -77,7 +77,7 @@ test_many_strings_with_common_prefix ()
 }
 
 static void
-test_strings_with_unicode_characters_that_have_common_prefix ()
+test_strings_with_unicode_characters_that_have_common_prefix (void)
 {
     GList *list = NULL;
     char *actual;
@@ -92,7 +92,7 @@ test_strings_with_unicode_characters_that_have_common_prefix ()
 }
 
 static void
-test_no_common_prefix ()
+test_no_common_prefix (void)
 {
     GList *list = NULL;
     char *actual;
@@ -107,7 +107,7 @@ test_no_common_prefix ()
 }
 
 static void
-test_has_common_prefix_but_smaller_than_min_required_length ()
+test_has_common_prefix_but_smaller_than_min_required_length (void)
 {
     GList *list = NULL;
     char *actual;
@@ -122,7 +122,7 @@ test_has_common_prefix_but_smaller_than_min_required_length ()
 }
 
 static void
-test_first_character_differs ()
+test_first_character_differs (void)
 {
     GList *list = NULL;
     char *actual;
@@ -137,7 +137,7 @@ test_first_character_differs ()
 }
 
 static void
-test_strings_with_unicode_characters_that_dont_have_common_prefix ()
+test_strings_with_unicode_characters_that_dont_have_common_prefix (void)
 {
     GList *list = NULL;
     char *actual;
@@ -153,7 +153,7 @@ test_strings_with_unicode_characters_that_dont_have_common_prefix ()
 
 
 static void
-setup_test_suite ()
+setup_test_suite (void)
 {
     g_test_add_func ("/get-common-prefix/1.0",
                      test_has_large_enough_common_prefix);
diff --git a/test/automated/displayless/test-file-utilities-get-common-filename-prefix.c 
b/test/automated/displayless/test-file-utilities-get-common-filename-prefix.c
index 0d78b97ee..4c044a0ac 100644
--- a/test/automated/displayless/test-file-utilities-get-common-filename-prefix.c
+++ b/test/automated/displayless/test-file-utilities-get-common-filename-prefix.c
@@ -13,7 +13,7 @@ free_list_and_result (GList *list,
 }
 
 static void
-test_has_large_enough_common_prefix ()
+test_has_large_enough_common_prefix (void)
 {
     GList *list = NULL;
     char *actual;
@@ -28,7 +28,7 @@ test_has_large_enough_common_prefix ()
 }
 
 static void
-test_has_large_enough_common_prefix_with_spaces_in_middle ()
+test_has_large_enough_common_prefix_with_spaces_in_middle (void)
 {
     GList *list = NULL;
     char *actual;
@@ -43,7 +43,7 @@ test_has_large_enough_common_prefix_with_spaces_in_middle ()
 }
 
 static void
-test_has_large_enough_common_prefix_with_punctuation_in_middle ()
+test_has_large_enough_common_prefix_with_punctuation_in_middle (void)
 {
     GList *list = NULL;
     char *actual;
@@ -58,7 +58,7 @@ test_has_large_enough_common_prefix_with_punctuation_in_middle ()
 }
 
 static void
-test_has_large_enough_common_prefix_with_punctuation_in_middle_and_extension ()
+test_has_large_enough_common_prefix_with_punctuation_in_middle_and_extension (void)
 {
     GList *list = NULL;
     char *actual;
@@ -73,7 +73,7 @@ test_has_large_enough_common_prefix_with_punctuation_in_middle_and_extension ()
 }
 
 static void
-test_doesnt_have_large_enough_common_prefix ()
+test_doesnt_have_large_enough_common_prefix (void)
 {
     GList *list = NULL;
     char *actual;
@@ -88,7 +88,7 @@ test_doesnt_have_large_enough_common_prefix ()
 }
 
 static void
-test_doesnt_have_large_enough_common_prefix_completely_different_strings ()
+test_doesnt_have_large_enough_common_prefix_completely_different_strings (void)
 {
     GList *list = NULL;
     char *actual;
@@ -103,7 +103,7 @@ test_doesnt_have_large_enough_common_prefix_completely_different_strings ()
 }
 
 static void
-test_doesnt_have_large_enough_common_prefix_first_character_differs ()
+test_doesnt_have_large_enough_common_prefix_first_character_differs (void)
 {
     GList *list = NULL;
     char *actual;
@@ -118,7 +118,7 @@ test_doesnt_have_large_enough_common_prefix_first_character_differs ()
 }
 
 static void
-test_doesnt_have_large_enough_common_prefix_first_character_differs_longer_string ()
+test_doesnt_have_large_enough_common_prefix_first_character_differs_longer_string (void)
 {
     GList *list = NULL;
     char *actual;
@@ -133,7 +133,7 @@ test_doesnt_have_large_enough_common_prefix_first_character_differs_longer_strin
 }
 
 static void
-test_has_large_enough_common_prefix_until_extension_removed ()
+test_has_large_enough_common_prefix_until_extension_removed (void)
 {
     GList *list = NULL;
     char *actual;
@@ -148,7 +148,7 @@ test_has_large_enough_common_prefix_until_extension_removed ()
 }
 
 static void
-test_extension_is_removed ()
+test_extension_is_removed (void)
 {
     GList *list = NULL;
     char *actual;
@@ -163,7 +163,7 @@ test_extension_is_removed ()
 }
 
 static void
-test_whitespace_is_removed ()
+test_whitespace_is_removed (void)
 {
     GList *list = NULL;
     char *actual;
@@ -178,7 +178,7 @@ test_whitespace_is_removed ()
 }
 
 static void
-test_whitespace_and_extension_are_removed ()
+test_whitespace_and_extension_are_removed (void)
 {
     GList *list = NULL;
     char *actual;
@@ -208,7 +208,7 @@ test_punctuation_is_preserved (void)
 }
 
 static void
-test_unicode_on_outside ()
+test_unicode_on_outside (void)
 {
     GList *list = NULL;
     char *actual;
@@ -223,7 +223,7 @@ test_unicode_on_outside ()
 }
 
 static void
-test_unicode_on_inside ()
+test_unicode_on_inside (void)
 {
     GList *list = NULL;
     char *actual;
@@ -238,7 +238,7 @@ test_unicode_on_inside ()
 }
 
 static void
-test_unicode_whole_string ()
+test_unicode_whole_string (void)
 {
     GList *list = NULL;
     char *actual;
@@ -253,7 +253,7 @@ test_unicode_whole_string ()
 }
 
 static void
-test_unicode_extension ()
+test_unicode_extension (void)
 {
     GList *list = NULL;
     char *actual;
@@ -268,7 +268,7 @@ test_unicode_extension ()
 }
 
 static void
-test_unicode_with_punctuation ()
+test_unicode_with_punctuation (void)
 {
     GList *list = NULL;
     char *actual;
@@ -283,7 +283,7 @@ test_unicode_with_punctuation ()
 }
 
 static void
-test_many_strings ()
+test_many_strings (void)
 {
     GList *list = NULL;
     char *actual;
@@ -304,7 +304,7 @@ test_many_strings ()
 }
 
 static void
-test_many_strings_last_differs ()
+test_many_strings_last_differs (void)
 {
     GList *list = NULL;
     char *actual;
@@ -331,7 +331,7 @@ test_many_strings_last_differs ()
 }
 
 static void
-test_many_strings_first_differs ()
+test_many_strings_first_differs (void)
 {
     GList *list = NULL;
     char *actual;
@@ -358,7 +358,7 @@ test_many_strings_first_differs ()
 }
 
 static void
-test_smaller_min_length_and_does_have_common_prefix ()
+test_smaller_min_length_and_does_have_common_prefix (void)
 {
     GList *list = NULL;
     char *actual;
@@ -373,7 +373,7 @@ test_smaller_min_length_and_does_have_common_prefix ()
 }
 
 static void
-test_smaller_min_length_and_doesnt_have_common_prefix ()
+test_smaller_min_length_and_doesnt_have_common_prefix (void)
 {
     GList *list = NULL;
     char *actual;
@@ -389,7 +389,7 @@ test_smaller_min_length_and_doesnt_have_common_prefix ()
 
 
 static void
-setup_test_suite ()
+setup_test_suite (void)
 {
     g_test_add_func ("/get-common-filename-prefix/1.0",
                      test_has_large_enough_common_prefix);
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]