[libdazzle] build: add more warning settings

[Christian Hergert <chergert src gnome org>]

commit 9216c47704f5317d3823084594bcf70d87390837
Author: Christian Hergert <chergert redhat com>
Date:   Fri Jun 15 22:35:24 2018 -0700

    build: add more warning settings

 meson.build                    | 51 ++++++++++++++++++++++++++++++------------
 src/graphing/dzl-cpu-graph.c   |  2 +-
 tests/test-desktop-index.c     |  2 +-
 tests/test-suggestion-buffer.c |  4 ++--
 tests/test-tree.c              |  4 ++--
 tests/test-trie.c              | 14 ++++++------
 6 files changed, 50 insertions(+), 27 deletions(-)
---
diff --git a/meson.build b/meson.build
index de76d8c..478b523 100644
--- a/meson.build
+++ b/meson.build
@@ -45,33 +45,56 @@ global_c_args = []
 test_c_args = [
   '-Wcast-align',
   '-Wdeclaration-after-statement',
-  '-Wformat-nonliteral',
-  '-Wformat-security',
-  '-Wmissing-include-dirs',
-  '-Wnested-externs',
-  '-Wno-missing-field-initializers',
-  '-Wno-sign-compare',
-  '-Wno-unused-parameter',
-  '-Wpointer-arith',
-  '-Wredundant-decls',
-  '-Wswitch-default',
-  '-Wswitch-enum',
-  '-Wuninitialized',
-  ['-Werror=format-security', '-Werror=format=2' ],
+  '-Werror=address',
+  '-Werror=array-bounds',
   '-Werror=empty-body',
+  '-Werror=implicit',
   '-Werror=implicit-function-declaration',
   '-Werror=incompatible-pointer-types',
-  '-Werror=pointer-arith',
   '-Werror=init-self',
   '-Werror=int-conversion',
+  '-Werror=int-to-pointer-cast',
+  '-Werror=main',
   '-Werror=misleading-indentation',
+  '-Werror=missing-braces',
   '-Werror=missing-include-dirs',
+  '-Werror=nonnull',
   '-Werror=overflow',
   '-Werror=parenthesis',
+  '-Werror=pointer-arith',
+  '-Werror=pointer-to-int-cast',
+  '-Werror=redundant-decls',
   '-Werror=return-type',
+  '-Werror=sequence-point',
   '-Werror=shadow',
   '-Werror=strict-prototypes',
+  '-Werror=trigraphs',
   '-Werror=undef',
+  '-Werror=write-strings',
+  '-Wformat-nonliteral',
+  ['-Werror=format-security', '-Werror=format=2' ],
+  '-Wignored-qualifiers',
+  '-Wimplicit-function-declaration',
+  '-Wlogical-op',
+  # '-Wmissing-declarations',
+  '-Wmissing-format-attribute',
+  '-Wmissing-include-dirs',
+  '-Wmissing-noreturn',
+  '-Wnested-externs',
+  '-Wno-cast-function-type',
+  '-Wno-missing-field-initializers',
+  '-Wno-sign-compare',
+  '-Wno-unused-parameter',
+  '-Wold-style-definition',
+  '-Wpointer-arith',
+  '-Wredundant-decls',
+  '-Wstrict-prototypes',
+  '-Wswitch-default',
+  '-Wswitch-enum',
+  '-Wundef',
+  '-Wuninitialized',
+  '-Wunused',
+  '-fno-strict-aliasing',
 ]
 if get_option('buildtype') != 'plain'
   test_c_args += '-fstack-protector-strong'
diff --git a/src/graphing/dzl-cpu-graph.c b/src/graphing/dzl-cpu-graph.c
index 9d07713..52b10bc 100644
--- a/src/graphing/dzl-cpu-graph.c
+++ b/src/graphing/dzl-cpu-graph.c
@@ -43,7 +43,7 @@ enum {
 
 static GParamSpec *properties[LAST_PROP];
 
-static gchar *colors[] = {
+static const gchar *colors[] = {
   "#73d216",
   "#f57900",
   "#3465a4",
diff --git a/tests/test-desktop-index.c b/tests/test-desktop-index.c
index b1f7909..5ff6114 100644
--- a/tests/test-desktop-index.c
+++ b/tests/test-desktop-index.c
@@ -327,7 +327,7 @@ main (gint   argc,
   for (guint i = 1; i < argc; i++)
     g_ptr_array_add (ar, argv[i]);
   if (ar->len == 0)
-    g_ptr_array_add (ar, "/usr/share/applications");
+    g_ptr_array_add (ar, (gchar *)"/usr/share/applications");
 
   for (guint i = 0; i < ar->len; i++)
     {
diff --git a/tests/test-suggestion-buffer.c b/tests/test-suggestion-buffer.c
index 4d63377..36b644a 100644
--- a/tests/test-suggestion-buffer.c
+++ b/tests/test-suggestion-buffer.c
@@ -25,10 +25,10 @@ test_basic (void)
   dzl_suggestion_set_title (suggestion, "this is the title");
   dzl_suggestion_set_subtitle (suggestion, "this is the subtitle");
   dzl_suggestion_set_icon_name (suggestion, "gtk-missing-symbolic");
-  g_signal_connect (suggestion, "suggest-suffix", G_CALLBACK (suggest_suffix), "abcd");
+  g_signal_connect (suggestion, "suggest-suffix", G_CALLBACK (suggest_suffix), (gchar *)"abcd");
 
   suggestion2 = dzl_suggestion_new ();
-  g_signal_connect (suggestion2, "suggest-suffix", G_CALLBACK (suggest_suffix), "99999");
+  g_signal_connect (suggestion2, "suggest-suffix", G_CALLBACK (suggest_suffix), (gchar *)"99999");
 
   dzl_suggestion_entry_buffer_set_suggestion (buffer, suggestion);
   g_assert (suggestion == dzl_suggestion_entry_buffer_get_suggestion (buffer));
diff --git a/tests/test-tree.c b/tests/test-tree.c
index 699f504..a03afdb 100644
--- a/tests/test-tree.c
+++ b/tests/test-tree.c
@@ -179,8 +179,8 @@ main (gint   argc,
       gchar *argv[])
 {
   static const GtkTargetEntry drag_targets[] = {
-    { "GTK_TREE_MODEL_ROW", GTK_TARGET_SAME_WIDGET, 0 },
-    { "text/uri-list", 0, 0 },
+    { (gchar *)"GTK_TREE_MODEL_ROW", GTK_TARGET_SAME_WIDGET, 0 },
+    { (gchar *)"text/uri-list", 0, 0 },
   };
   g_autoptr(DzlTreeNode) root = NULL;
   g_autoptr(GFile) home = NULL;
diff --git a/tests/test-trie.c b/tests/test-trie.c
index 88b0f47..5d95d2e 100644
--- a/tests/test-trie.c
+++ b/tests/test-trie.c
@@ -6,19 +6,19 @@ test_dzl_trie_insert (void)
    DzlTrie *trie;
 
    trie = dzl_trie_new(NULL);
-   dzl_trie_insert(trie, "a", "a");
+   dzl_trie_insert(trie, "a", (gchar *)"a");
    g_assert_cmpstr("a", ==, dzl_trie_lookup(trie, "a"));
-   dzl_trie_insert(trie, "b", "b");
+   dzl_trie_insert(trie, "b", (gchar *)"b");
    g_assert_cmpstr("b", ==, dzl_trie_lookup(trie, "b"));
-   dzl_trie_insert(trie, "c", "c");
+   dzl_trie_insert(trie, "c", (gchar *)"c");
    g_assert_cmpstr("c", ==, dzl_trie_lookup(trie, "c"));
-   dzl_trie_insert(trie, "d", "d");
+   dzl_trie_insert(trie, "d", (gchar *)"d");
    g_assert_cmpstr("d", ==, dzl_trie_lookup(trie, "d"));
-   dzl_trie_insert(trie, "e", "e");
+   dzl_trie_insert(trie, "e", (gchar *)"e");
    g_assert_cmpstr("e", ==, dzl_trie_lookup(trie, "e"));
-   dzl_trie_insert(trie, "f", "f");
+   dzl_trie_insert(trie, "f", (gchar *)"f");
    g_assert_cmpstr("f", ==, dzl_trie_lookup(trie, "f"));
-   dzl_trie_insert(trie, "g", "g");
+   dzl_trie_insert(trie, "g", (gchar *)"g");
    g_assert_cmpstr("g", ==, dzl_trie_lookup(trie, "g"));
    dzl_trie_destroy(trie);
 }