GNOME.org
 

[gnome-builder] libide: fix various -Wmissing-declarations

commit 66590d42d2565e66f2969df69cb96ffe8cf27937
Author: Christian Hergert <chergert redhat com>
Date:   Fri Jun 15 21:44:16 2018 -0700

    libide: fix various -Wmissing-declarations

 src/libide/buffers/ide-unsaved-files.c         |  2 +-
 src/libide/buildsystem/ide-build-stage.c       |  1 +
 src/libide/completion/ide-completion-overlay.c |  8 +++++---
 src/libide/completion/ide-completion-window.c  | 10 +++++-----
 src/libide/config/ide-configuration-provider.c |  6 +++---
 src/libide/config/ide-configuration.c          |  1 +
 src/libide/debugger/ide-debugger-breakpoint.c  |  1 +
 src/libide/devices/ide-device-manager.c        |  2 +-
 src/libide/editor/ide-editor-sidebar.c         |  1 +
 src/libide/meson.build                         |  1 -
 src/libide/projects/ide-project-info.h         |  3 +++
 src/libide/snippets/ide-snippet.c              |  2 +-
 src/libide/sourceview/ide-source-view-mode.c   |  4 ++--
 src/libide/toolchain/ide-simple-toolchain.c    |  4 ++--
 src/libide/toolchain/ide-toolchain-manager.c   |  1 +
 src/libide/toolchain/ide-toolchain-provider.c  |  2 +-
 16 files changed, 29 insertions(+), 20 deletions(-)
---
diff --git a/src/libide/buffers/ide-unsaved-files.c b/src/libide/buffers/ide-unsaved-files.c
index ac43f1938..f4989050a 100644
--- a/src/libide/buffers/ide-unsaved-files.c
+++ b/src/libide/buffers/ide-unsaved-files.c
@@ -69,7 +69,7 @@ static void ide_unsaved_files_update_locked (IdeUnsavedFiles *self,
                                              GFile           *file,
                                              GBytes          *content);
 
-gchar *
+static gchar *
 get_drafts_directory (IdeContext *context)
 {
   IdeProject *project;
diff --git a/src/libide/buildsystem/ide-build-stage.c b/src/libide/buildsystem/ide-build-stage.c
index 2599d1882..bdc83c4a2 100644
--- a/src/libide/buildsystem/ide-build-stage.c
+++ b/src/libide/buildsystem/ide-build-stage.c
@@ -26,6 +26,7 @@
 
 #include "buildsystem/ide-build-pipeline.h"
 #include "buildsystem/ide-build-stage.h"
+#include "buildsystem/ide-build-stage-private.h"
 #include "subprocess/ide-subprocess.h"
 #include "threading/ide-task.h"
 
diff --git a/src/libide/completion/ide-completion-overlay.c b/src/libide/completion/ide-completion-overlay.c
index 8a0d9b76d..66decb544 100644
--- a/src/libide/completion/ide-completion-overlay.c
+++ b/src/libide/completion/ide-completion-overlay.c
@@ -284,10 +284,12 @@ ide_completion_overlay_key_press_event (IdeCompletionDisplay *display,
   return _ide_completion_view_handle_key_press (self->view, event);
 }
 
-void
-ide_completion_overlay_set_context (IdeCompletionOverlay *self,
+static void
+ide_completion_overlay_set_context (IdeCompletionDisplay *display,
                                     IdeCompletionContext *context)
 {
+  IdeCompletionOverlay *self = (IdeCompletionOverlay *)display;
+
   g_return_if_fail (IDE_IS_COMPLETION_OVERLAY (self));
   g_return_if_fail (!context || IDE_IS_COMPLETION_CONTEXT (context));
 
@@ -317,7 +319,7 @@ ide_completion_overlay_set_font_desc (IdeCompletionDisplay       *display,
 static void
 completion_display_iface_init (IdeCompletionDisplayInterface *iface)
 {
-  iface->set_context = (gpointer)ide_completion_overlay_set_context;
+  iface->set_context = ide_completion_overlay_set_context;
   iface->attach = ide_completion_overlay_attach;
   iface->key_press_event = ide_completion_overlay_key_press_event;
   iface->set_n_rows = ide_completion_overlay_set_n_rows;
diff --git a/src/libide/completion/ide-completion-window.c b/src/libide/completion/ide-completion-window.c
index 0714a31d1..c7e5ae369 100644
--- a/src/libide/completion/ide-completion-window.c
+++ b/src/libide/completion/ide-completion-window.c
@@ -60,8 +60,8 @@ static void (*MoveToRect) (GdkWindow          *window,
                            gint                rect_anchor_dx,
                            gint                rect_anchor_dy);
 
-gboolean
-_ide_completion_window_reposition (IdeCompletionWindow *self)
+static gboolean
+ide_completion_window_reposition (IdeCompletionWindow *self)
 {
   IdeCompletionContext *context;
   GtkRequisition min, nat;
@@ -143,7 +143,7 @@ ide_completion_window_real_show (GtkWidget *widget)
 
   g_assert (IDE_IS_COMPLETION_WINDOW (self));
 
-  _ide_completion_window_reposition (self);
+  ide_completion_window_reposition (self);
 
   GTK_WIDGET_CLASS (ide_completion_window_parent_class)->show (widget);
 }
@@ -165,7 +165,7 @@ ide_completion_window_real_realize (GtkWidget *widget)
 
   GTK_WIDGET_CLASS (ide_completion_window_parent_class)->realize (widget);
 
-  _ide_completion_window_reposition (self);
+  ide_completion_window_reposition (self);
 }
 
 static void
@@ -265,7 +265,7 @@ ide_completion_window_init (IdeCompletionWindow *self)
 
   g_signal_connect_swapped (self->view,
                             "reposition",
-                            G_CALLBACK (_ide_completion_window_reposition),
+                            G_CALLBACK (ide_completion_window_reposition),
                             self);
 }
 
diff --git a/src/libide/config/ide-configuration-provider.c b/src/libide/config/ide-configuration-provider.c
index 62cea7dfe..c74a5bf49 100644
--- a/src/libide/config/ide-configuration-provider.c
+++ b/src/libide/config/ide-configuration-provider.c
@@ -53,7 +53,7 @@ ide_configuration_provider_real_load_async (IdeConfigurationProvider *self,
                            G_OBJECT_TYPE_NAME (self));
 }
 
-gboolean
+static gboolean
 ide_configuration_provider_real_load_finish (IdeConfigurationProvider  *self,
                                              GAsyncResult              *result,
                                              GError                   **error)
@@ -84,7 +84,7 @@ ide_configuration_provider_real_unload (IdeConfigurationProvider *self)
 
 }
 
-void
+static void
 ide_configuration_provider_real_save_async (IdeConfigurationProvider *self,
                                             GCancellable             *cancellable,
                                             GAsyncReadyCallback       callback,
@@ -102,7 +102,7 @@ ide_configuration_provider_real_save_async (IdeConfigurationProvider *self,
                            G_OBJECT_TYPE_NAME (self));
 }
 
-gboolean
+static gboolean
 ide_configuration_provider_real_save_finish (IdeConfigurationProvider  *self,
                                              GAsyncResult              *result,
                                              GError                   **error)
diff --git a/src/libide/config/ide-configuration.c b/src/libide/config/ide-configuration.c
index df3d9cb1c..7b6f24395 100644
--- a/src/libide/config/ide-configuration.c
+++ b/src/libide/config/ide-configuration.c
@@ -29,6 +29,7 @@
 #include "application/ide-application.h"
 #include "config/ide-configuration.h"
 #include "config/ide-configuration-manager.h"
+#include "config/ide-configuration-private.h"
 #include "buildsystem/ide-environment.h"
 #include "runtimes/ide-runtime-manager.h"
 #include "runtimes/ide-runtime.h"
diff --git a/src/libide/debugger/ide-debugger-breakpoint.c b/src/libide/debugger/ide-debugger-breakpoint.c
index 0c3a5ef07..bff924e19 100644
--- a/src/libide/debugger/ide-debugger-breakpoint.c
+++ b/src/libide/debugger/ide-debugger-breakpoint.c
@@ -21,6 +21,7 @@
 #include "config.h"
 
 #include "debugger/ide-debugger-breakpoint.h"
+#include "debugger/ide-debugger-private.h"
 #include "debugger/ide-debugger-types.h"
 
 typedef struct
diff --git a/src/libide/devices/ide-device-manager.c b/src/libide/devices/ide-device-manager.c
index 0af4d1985..9d469c765 100644
--- a/src/libide/devices/ide-device-manager.c
+++ b/src/libide/devices/ide-device-manager.c
@@ -418,7 +418,7 @@ ide_device_manager_get_n_items (GListModel *list_model)
   return self->devices->len;
 }
 
-gpointer
+static gpointer
 ide_device_manager_get_item (GListModel *list_model,
                              guint       position)
 {
diff --git a/src/libide/editor/ide-editor-sidebar.c b/src/libide/editor/ide-editor-sidebar.c
index e51a01b8c..54815880b 100644
--- a/src/libide/editor/ide-editor-sidebar.c
+++ b/src/libide/editor/ide-editor-sidebar.c
@@ -22,6 +22,7 @@
 
 #include <dazzle.h>
 
+#include "editor/ide-editor-private.h"
 #include "editor/ide-editor-sidebar.h"
 #include "layout/ide-layout-private.h"
 #include "layout/ide-layout-stack.h"
diff --git a/src/libide/meson.build b/src/libide/meson.build
index 8365cf957..f9c0368a3 100644
--- a/src/libide/meson.build
+++ b/src/libide/meson.build
@@ -6,7 +6,6 @@ libide_generated_headers = []
 libide_public_headers = []
 libide_public_sources = []
 libide_private_sources = []
-libide_args = []
 
 version_data = configuration_data()
 version_data.set('MAJOR_VERSION', MAJOR_VERSION)
diff --git a/src/libide/projects/ide-project-info.h b/src/libide/projects/ide-project-info.h
index 1eef2f6c3..e4b18661e 100644
--- a/src/libide/projects/ide-project-info.h
+++ b/src/libide/projects/ide-project-info.h
@@ -55,6 +55,9 @@ gint          ide_project_info_get_priority          (IdeProjectInfo  *self);
 IDE_AVAILABLE_IN_ALL
 GDateTime    *ide_project_info_get_last_modified_at  (IdeProjectInfo  *self);
 IDE_AVAILABLE_IN_ALL
+void          ide_project_info_set_last_modified_at  (IdeProjectInfo  *self,
+                                                      GDateTime       *modified_at);
+IDE_AVAILABLE_IN_ALL
 const gchar * const *
               ide_project_info_get_languages         (IdeProjectInfo  *self);
 IDE_AVAILABLE_IN_ALL
diff --git a/src/libide/snippets/ide-snippet.c b/src/libide/snippets/ide-snippet.c
index 10dd48892..6abdb9fa6 100644
--- a/src/libide/snippets/ide-snippet.c
+++ b/src/libide/snippets/ide-snippet.c
@@ -755,7 +755,7 @@ ide_snippet_add_chunk (IdeSnippet      *self,
   self->max_tab_stop = MAX (self->max_tab_stop, tab_stop);
 }
 
-gchar *
+static gchar *
 ide_snippet_get_nth_text (IdeSnippet *self,
                           gint        n)
 {
diff --git a/src/libide/sourceview/ide-source-view-mode.c b/src/libide/sourceview/ide-source-view-mode.c
index e8abe69e7..d8907e3ab 100644
--- a/src/libide/sourceview/ide-source-view-mode.c
+++ b/src/libide/sourceview/ide-source-view-mode.c
@@ -65,7 +65,7 @@ get_param (IdeSourceViewMode *self,
   gtk_style_context_get_style_property (context, param, value);
 }
 
-gboolean
+static gboolean
 get_boolean_param (IdeSourceViewMode *self,
                    const gchar       *param)
 {
@@ -80,7 +80,7 @@ get_boolean_param (IdeSourceViewMode *self,
   return ret;
 }
 
-gchar *
+static gchar *
 get_string_param (IdeSourceViewMode *self,
                   const gchar       *param)
 {
diff --git a/src/libide/toolchain/ide-simple-toolchain.c b/src/libide/toolchain/ide-simple-toolchain.c
index 3742f8cae..13327753f 100644
--- a/src/libide/toolchain/ide-simple-toolchain.c
+++ b/src/libide/toolchain/ide-simple-toolchain.c
@@ -75,7 +75,7 @@ tools_find_all_id (gpointer key,
     g_hash_table_insert (tool_find->found_tools, g_strdup (tool_parts[1]), g_strdup (tool_path));
 }
 
-GHashTable *
+static GHashTable *
 ide_simple_toolchain_get_tools_for_id (IdeToolchain  *toolchain,
                                        const gchar   *tool_id)
 {
@@ -98,7 +98,7 @@ ide_simple_toolchain_get_tools_for_id (IdeToolchain  *toolchain,
   return g_steal_pointer (&found_tools);
 }
 
-const gchar *
+static const gchar *
 ide_simple_toolchain_get_tool_for_language (IdeToolchain  *toolchain,
                                             const gchar   *language,
                                             const gchar   *tool_id)
diff --git a/src/libide/toolchain/ide-toolchain-manager.c b/src/libide/toolchain/ide-toolchain-manager.c
index efa2a8056..d2fd252ec 100644
--- a/src/libide/toolchain/ide-toolchain-manager.c
+++ b/src/libide/toolchain/ide-toolchain-manager.c
@@ -36,6 +36,7 @@
 #include "toolchain/ide-simple-toolchain.h"
 #include "toolchain/ide-toolchain.h"
 #include "toolchain/ide-toolchain-manager.h"
+#include "toolchain/ide-toolchain-private.h"
 #include "toolchain/ide-toolchain-provider.h"
 
 struct _IdeToolchainManager
diff --git a/src/libide/toolchain/ide-toolchain-provider.c b/src/libide/toolchain/ide-toolchain-provider.c
index e0e0665e3..2705aeb3a 100644
--- a/src/libide/toolchain/ide-toolchain-provider.c
+++ b/src/libide/toolchain/ide-toolchain-provider.c
@@ -55,7 +55,7 @@ ide_toolchain_provider_real_load_async (IdeToolchainProvider *self,
                            G_OBJECT_TYPE_NAME (self));
 }
 
-gboolean
+static gboolean
 ide_toolchain_provider_real_load_finish (IdeToolchainProvider  *self,
                                          GAsyncResult          *result,
                                          GError               **error)
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]