[gdm: 1/8] libgdm: Unref the manager propagated from task



commit 4d2da18f7d3fa79aeededcd1760d3a1ab75adfeb
Author: Marco Trevisan (TreviƱo) <mail 3v1n0 net>
Date:   Fri Jun 1 17:07:41 2018 +0200

    libgdm: Unref the manager propagated from task
    
    This instance has already been reffed when passed to the task, and since
    we're stealing it with `g_task_propagate_pointer` it won't be unreffed.
    
    We could also do this in the `on_reauthentication_channel_opened` callback
    but since the new task will ref it anyway, we can just be clean and do it
    here.

 libgdm/gdm-client.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/libgdm/gdm-client.c b/libgdm/gdm-client.c
index f327344e..fa4ba842 100644
--- a/libgdm/gdm-client.c
+++ b/libgdm/gdm-client.c
@@ -390,7 +390,7 @@ on_got_manager_for_reauthentication (GdmClient           *client,
                                                         (GAsyncReadyCallback)
                                                         on_reauthentication_channel_opened,
                                                         task);
-
+        g_object_unref (manager);
 }
 
 static GDBusConnection *
@@ -527,6 +527,8 @@ on_got_manager_for_opening_connection (GdmClient           *client,
                                        (GAsyncReadyCallback)
                                        on_session_opened,
                                        task);
+
+        g_object_unref (manager);
 }
 
 static GDBusConnection *


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]