[gnome-builder/wip/chergert/completion] python: remove format provider



commit e621916a93db09a510c9f2db836c0601d72da4f7
Author: Christian Hergert <chergert redhat com>
Date:   Sun Jun 3 13:26:30 2018 -0700

    python: remove format provider
    
    This wasn't really getting used anyway, and more importantly, we
    need to come up with a generic interface to specify these for
    languages so it doesn't require stupid code like this.

 .../python-pack/ide-python-format-provider.c       | 270 ---------------------
 .../python-pack/ide-python-format-provider.h       |  30 ---
 src/plugins/python-pack/meson.build                |   2 -
 src/plugins/python-pack/python-pack-plugin.c       |  10 -
 4 files changed, 312 deletions(-)
---
diff --git a/src/plugins/python-pack/meson.build b/src/plugins/python-pack/meson.build
index 1aef9eb1b..bdddd8818 100644
--- a/src/plugins/python-pack/meson.build
+++ b/src/plugins/python-pack/meson.build
@@ -9,8 +9,6 @@ python_pack_resources = gnome.compile_resources(
 python_pack_sources = [
   'ide-python-indenter.c',
   'ide-python-indenter.h',
-  'ide-python-format-provider.c',
-  'ide-python-format-provider.h',
   'python-pack-plugin.c',
 ]
 
diff --git a/src/plugins/python-pack/python-pack-plugin.c b/src/plugins/python-pack/python-pack-plugin.c
index a143b817b..ed18cc7bf 100644
--- a/src/plugins/python-pack/python-pack-plugin.c
+++ b/src/plugins/python-pack/python-pack-plugin.c
@@ -19,23 +19,13 @@
 #include <libpeas/peas.h>
 
 #include "ide-python-indenter.h"
-#include "ide-python-format-provider.h"
 
 void _ide_python_indenter_register_type (GTypeModule *module);
-void _ide_python_format_provider_register_type (GTypeModule *module);
 
 void
 ide_python_pack_register_types (PeasObjectModule *module)
 {
   _ide_python_indenter_register_type (G_TYPE_MODULE (module));
-  _ide_python_format_provider_register_type (G_TYPE_MODULE (module));
 
   peas_object_module_register_extension_type (module, IDE_TYPE_INDENTER, IDE_TYPE_PYTHON_INDENTER);
-  /*
-   * TODO: I think we should make a generic interface for format providers
-   *       so that we don't take up a "completion provider" for them in the
-   *       plugins. That way, the sourceview can own the completion provider
-   *       and change the format provider when the language changes.
-   */
-  peas_object_module_register_extension_type (module, IDE_TYPE_COMPLETION_PROVIDER, 
IDE_TYPE_PYTHON_FORMAT_PROVIDER);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]