[gnome-builder/wip/chergert/completion] completion: destroy widget in dispose



commit 1f6872c9d12005c5809d191a298c397b6d40c372
Author: Christian Hergert <chergert redhat com>
Date:   Sat Jun 2 19:22:59 2018 -0700

    completion: destroy widget in dispose

 src/libide/completion/ide-completion.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/src/libide/completion/ide-completion.c b/src/libide/completion/ide-completion.c
index 45cd89a4b..f9fedcb97 100644
--- a/src/libide/completion/ide-completion.c
+++ b/src/libide/completion/ide-completion.c
@@ -914,6 +914,11 @@ ide_completion_dispose (GObject *object)
 
   g_assert (IDE_IS_COMPLETION (self));
 
+  if (self->display != NULL)
+    gtk_widget_destroy (GTK_WIDGET (self->display));
+
+  g_assert (self->display == NULL);
+
   dzl_signal_group_set_target (self->context_signals, NULL);
   dzl_signal_group_set_target (self->buffer_signals, NULL);
   dzl_signal_group_set_target (self->view_signals, NULL);
@@ -936,9 +941,6 @@ ide_completion_finalize (GObject *object)
 
   IDE_ENTRY;
 
-  if (self->display != NULL)
-    gtk_widget_destroy (GTK_WIDGET (self->display));
-
   dzl_clear_source (&self->queued_update);
 
   g_clear_object (&self->cancellable);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]