[gnome-shell] system: Don't execute Settings

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit f433b12d6e7110031a46f74b83d3318b1f242fd8
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Jul 31 13:23:05 2018 -0300

    system: Don't execute Settings
    
    In a9ad91c831, a bug was introduced in the following code:
    
    ```c
                this._settingsAction.connect('clicked',
                                             this._onSettingsClicked().bind(this));
    ```
    
    Notice that the callback is being executed! This commit
    fixes that by removing the '()' from the callback.

 js/ui/status/system.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/status/system.js b/js/ui/status/system.js
index 81b985c1f..c695f37be 100644
--- a/js/ui/status/system.js
+++ b/js/ui/status/system.js
@@ -269,7 +269,7 @@ var Indicator = new Lang.Class({
                                 app.get_name()];
             this._settingsAction = this._createActionButton(icon, name);
             this._settingsAction.connect('clicked',
-                                         this._onSettingsClicked().bind(this));
+                                         this._onSettingsClicked.bind(this));
         } else {
             log('Missing required core component Settings, expect trouble…');
             this._settingsAction = new St.Widget();