[gnome-software/wip/hughsie/FlatpakTransaction] f-transaction



commit 9d87cf23267615320488b21b89f6f4b65a877e45
Author: Richard Hughes <richard hughsie com>
Date:   Thu Jul 12 12:27:36 2018 +0100

    f-transaction

 plugins/flatpak/gs-flatpak-transaction.c | 4 ++--
 plugins/flatpak/gs-flatpak-transaction.h | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)
---
diff --git a/plugins/flatpak/gs-flatpak-transaction.c b/plugins/flatpak/gs-flatpak-transaction.c
index 0b75f0e0..dbc7af9c 100644
--- a/plugins/flatpak/gs-flatpak-transaction.c
+++ b/plugins/flatpak/gs-flatpak-transaction.c
@@ -109,9 +109,10 @@ static gboolean
 _transaction_ready (FlatpakTransaction *transaction)
 {
        GsFlatpakTransaction *self = GS_FLATPAK_TRANSACTION (transaction);
-       GList *ops = flatpak_transaction_get_operations (transaction);
+       g_autolist(GObject) ops = NULL;
 
        /* nothing to do */
+       ops = flatpak_transaction_get_operations (transaction);
        if (ops == NULL)
                return TRUE; // FIXME: error?
        for (GList *l = ops; l != NULL; l = l->next) {
@@ -120,7 +121,6 @@ _transaction_ready (FlatpakTransaction *transaction)
                g_autoptr(GsApp) app = _ref_to_app (self, ref);
                if (app != NULL)
                        _transaction_operation_set_app (op, app);
-               g_object_unref (op);
        }
        return TRUE;
 }
diff --git a/plugins/flatpak/gs-flatpak-transaction.h b/plugins/flatpak/gs-flatpak-transaction.h
index d119c31c..56b6a676 100644
--- a/plugins/flatpak/gs-flatpak-transaction.h
+++ b/plugins/flatpak/gs-flatpak-transaction.h
@@ -1,7 +1,6 @@
 /* -*- Mode: C; tab-width: 8; indent-tabs-mode: t; c-basic-offset: 8 -*-
  *
- * Copyright (C) 2016 Joaquim Rocha <jrocha endlessm com>
- * Copyright (C) 2016-2018 Richard Hughes <richard hughsie com>
+ * Copyright (C) 2018 Richard Hughes <richard hughsie com>
  *
  * Licensed under the GNU General Public License Version 2
  *


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]