[gjs] Revert "object: reset the keep alive flag on wrapper when object is disposed"
- From: Philip Chimento <pchimento src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gjs] Revert "object: reset the keep alive flag on wrapper when object is disposed"
- Date: Sat, 27 Jan 2018 22:32:16 +0000 (UTC)
commit b2dba685ca65c2185201b7586a0cd1c5fb9e0c4e
Author: Philip Chimento <philip chimento gmail com>
Date: Sat Jan 27 14:28:17 2018 -0800
Revert "object: reset the keep alive flag on wrapper when object is disposed"
This reverts commit 81225d067160a6850eb513ef44b393aeb24ac3ea.
It was an optional suggestion from me on the original patchset, that I
thought would let the JS wrappers for finalized objects get garbage
collected earlier. But it doesn't work as intended, so we can just drop
it.
Closes #33.
gi/object.cpp | 1 -
1 file changed, 1 deletion(-)
---
diff --git a/gi/object.cpp b/gi/object.cpp
index baa9a78..3567ff5 100644
--- a/gi/object.cpp
+++ b/gi/object.cpp
@@ -953,7 +953,6 @@ wrapped_gobj_dispose_notify(gpointer data,
auto *priv = static_cast<ObjectInstance *>(data);
priv->g_object_finalized = true;
- priv->keep_alive.reset();
wrapped_gobject_list.erase(priv);
#if DEBUG_DISPOSE
gjs_debug(GJS_DEBUG_GOBJECT, "Wrapped GObject %p disposed", where_the_object_was);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]