[gnome-builder] gjs-symbols: Always return errors on failure
- From: Patrick Griffis <pgriffis src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] gjs-symbols: Always return errors on failure
- Date: Thu, 18 Jan 2018 15:22:22 +0000 (UTC)
commit 7e13b23942cc969b5d5d0a3d6122571026fe385a
Author: Patrick Griffis <tingping tingping se>
Date: Thu Jan 18 10:20:33 2018 -0500
gjs-symbols: Always return errors on failure
src/plugins/gjs-symbols/gjs_symbols.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/src/plugins/gjs-symbols/gjs_symbols.py b/src/plugins/gjs-symbols/gjs_symbols.py
index 85fc7232d..93468766b 100644
--- a/src/plugins/gjs-symbols/gjs_symbols.py
+++ b/src/plugins/gjs-symbols/gjs_symbols.py
@@ -279,7 +279,7 @@ class GjsSymbolProvider(Ide.Object, Ide.SymbolResolver):
def do_lookup_symbol_async(self, location, cancellable, callback, user_data=None):
task = Gio.Task.new(self, cancellable, callback)
- task.return_boolean(False) # Not implemented
+ task.return_error(GLib.Error('Not implemented'))
def do_lookup_symbol_finish(self, result):
result.propagate_boolean()
@@ -298,7 +298,7 @@ class GjsSymbolProvider(Ide.Object, Ide.SymbolResolver):
success, stdout, stderr = proc.communicate_utf8(None, None)
if not success:
- task.return_boolean(False)
+ task.return_error(GLib.Error('Failed to run gjs'))
return
ide_file = Ide.File(file=file_, context=self.get_context())
@@ -321,7 +321,7 @@ class GjsSymbolProvider(Ide.Object, Ide.SymbolResolver):
def do_find_references_async(self, location, cancellable, callback, user_data=None):
task = Gio.Task.new(self, cancellable, callback)
- task.return_boolean(False) # Not implemented
+ task.return_error(GLib.Error('Not implemented'))
def do_find_references_finish(self, result):
result.propagate_boolean()
@@ -329,7 +329,7 @@ class GjsSymbolProvider(Ide.Object, Ide.SymbolResolver):
def do_find_nearest_scope_async(self, location, cancellable, callback, user_data=None):
task = Gio.Task.new(self, cancellable, callback)
- task.return_boolean(False) # Not implemented
+ task.return_error(GLib.Error('Not implemented'))
def do_find_nearest_scope_finish(self, result):
result.propagate_boolean()
@@ -426,7 +426,7 @@ class GjsCodeIndexer(Ide.Object, Ide.CodeIndexer):
def do_generate_key_async(self, location, cancellable, callback, user_data=None):
# print('generate key')
task = Gio.Task.new(self, cancellable, callback)
- task.return_boolean(False)
+ task.return_error(GLib.Error('Not implemented'))
def do_generate_key_finish(self, result):
if result.propagate_boolean():
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]