[gnome-builder] configuration: keep ownership transfer where it is used



commit c21a905aff1cd591fd8ac1465b56a9962ddc1420
Author: Christian Hergert <chergert redhat com>
Date:   Fri Jan 12 20:42:47 2018 -0800

    configuration: keep ownership transfer where it is used

 src/libide/buildconfig/ide-buildconfig-configuration-provider.c | 4 ++--
 src/libide/buildsystem/ide-configuration-manager.c              | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/src/libide/buildconfig/ide-buildconfig-configuration-provider.c 
b/src/libide/buildconfig/ide-buildconfig-configuration-provider.c
index 35adf7f7a..a195843dd 100644
--- a/src/libide/buildconfig/ide-buildconfig-configuration-provider.c
+++ b/src/libide/buildconfig/ide-buildconfig-configuration-provider.c
@@ -630,7 +630,7 @@ ide_buildconfig_configuration_provider_track_config (IdeBuildconfigConfiguration
                                                      IdeBuildconfigConfiguration         *config)
 {
   g_assert (IDE_IS_BUILDCONFIG_CONFIGURATION_PROVIDER (self));
-  g_return_if_fail (IDE_IS_BUILDCONFIG_CONFIGURATION (config));
+  g_assert (IDE_IS_BUILDCONFIG_CONFIGURATION (config));
 
   g_signal_connect_object (config,
                            "changed",
@@ -638,7 +638,7 @@ ide_buildconfig_configuration_provider_track_config (IdeBuildconfigConfiguration
                            self,
                            G_CONNECT_SWAPPED);
 
-  g_ptr_array_add (self->configurations, config);
+  g_ptr_array_add (self->configurations, g_object_ref (config));
 }
 
 static void
diff --git a/src/libide/buildsystem/ide-configuration-manager.c 
b/src/libide/buildsystem/ide-configuration-manager.c
index b12cd5e1b..5cb45aa49 100644
--- a/src/libide/buildsystem/ide-configuration-manager.c
+++ b/src/libide/buildsystem/ide-configuration-manager.c
@@ -406,10 +406,11 @@ ide_configuration_manager_track_buildconfig (PeasExtensionSet *set,
   g_assert (PEAS_IS_EXTENSION_SET (set));
   g_assert (plugin_info != NULL);
   g_assert (IDE_IS_CONFIGURATION_PROVIDER (provider));
+  g_assert (!config || IDE_IS_BUILDCONFIG_CONFIGURATION (config));
 
   if (IDE_IS_BUILDCONFIG_CONFIGURATION_PROVIDER (provider) && config != NULL)
-    ide_buildconfig_configuration_provider_track_config ((IdeBuildconfigConfigurationProvider *)provider,
-                                                         (IdeBuildconfigConfiguration *)g_object_ref 
(config));
+    ide_buildconfig_configuration_provider_track_config (IDE_BUILDCONFIG_CONFIGURATION_PROVIDER (provider),
+                                                         IDE_BUILDCONFIG_CONFIGURATION (config));
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]