[devhelp/wip/flatpak: 5/5] flatpak: see books installed on the host

[Sébastien Wilmet <swilmet src gnome org>]

commit 89c00b51276eb6249fd47859532f1664d2075518
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Fri Jan 12 20:32:07 2018 +0100

    flatpak: see books installed on the host
    
    https://bugzilla.gnome.org/show_bug.cgi?id=792068

 src/dh-book-manager.c |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+), 0 deletions(-)
---
diff --git a/src/dh-book-manager.c b/src/dh-book-manager.c
index da7c344..50961a8 100644
--- a/src/dh-book-manager.c
+++ b/src/dh-book-manager.c
@@ -806,6 +806,25 @@ populate (DhBookManager *book_manager)
         for (i = 0; system_dirs[i] != NULL; i++) {
                 find_books_in_data_dir (book_manager, system_dirs[i]);
         }
+
+        /* For Flatpak, to see the books installed on the host by traditional
+         * Linux distro packages.
+         *
+         * It is not a good idea to add the directory to XDG_DATA_DIRS, see:
+         * https://github.com/flatpak/flatpak/issues/1299
+         * "all sorts of things will break if we add all host config to each
+         * app, which is totally opposite to the entire point of flatpak."
+         * "i don't think XDG_DATA_DIRS is the right thing, because all sorts of
+         * libraries will start reading files from there, like dconf, dbus,
+         * service files, mimetypes, etc. It would be preferable to have
+         * something that targeted just gtk-doc files."
+         *
+         * So instead of adapting XDG_DATA_DIRS, add the directory here, with
+         * the path hard-coded.
+         *
+         * https://bugzilla.gnome.org/show_bug.cgi?id=792068
+         */
+        find_books_in_data_dir (book_manager, "/run/host/usr/share");
 }
 
 static void