[gimp] Bug 784176 - Tags are exchanged between different assets...



commit 1a23115024397584e2065c38fc706155346e3262
Author: Michael Natterer <mitch gimp org>
Date:   Thu Jan 11 21:30:37 2018 +0100

    Bug 784176 - Tags are exchanged between different assets...
    
    ...on the list dialogs on the Input text area
    
    gimp_container_editor_constructed(): connect the container
    view's "select-item" with G_CONNECT_AFTER because the signal
    is G_SIGNAL_RUN_LAST. Some quick greps didn't find anything that
    would be affected, except fixing this bug. Found by Massimo.

 app/widgets/gimpcontainereditor.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
---
diff --git a/app/widgets/gimpcontainereditor.c b/app/widgets/gimpcontainereditor.c
index fabe538..1c3c148 100644
--- a/app/widgets/gimpcontainereditor.c
+++ b/app/widgets/gimpcontainereditor.c
@@ -278,9 +278,14 @@ gimp_container_editor_constructed (GObject *object)
                       TRUE, TRUE, 0);
   gtk_widget_show (GTK_WIDGET (editor->view));
 
+  /*  Connect "select-item" with G_CONNECT_AFTER because it's a
+   *  RUN_LAST signal and the default handler selecting the row must
+   *  run before signal connections. See bug #784176.
+   */
   g_signal_connect_object (editor->view, "select-item",
                            G_CALLBACK (gimp_container_editor_select_item),
-                           editor, 0);
+                           editor, G_CONNECT_AFTER);
+
   g_signal_connect_object (editor->view, "activate-item",
                            G_CALLBACK (gimp_container_editor_activate_item),
                            editor, 0);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]