[gimp] Bug 790552 - do not save metadata by default.
- From: Jehan Pagès <jehanp src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] Bug 790552 - do not save metadata by default.
- Date: Wed, 10 Jan 2018 23:51:32 +0000 (UTC)
commit 096debb0fdb1bc41ca7b2f57f391285cf965539e
Author: Jehan <jehan girinstud io>
Date: Thu Jan 11 00:39:22 2018 +0100
Bug 790552 - do not save metadata by default.
This is a privacy concern. Whereas importing metadata is usually a good
idea, exporting it should be a conscious action. A lot of private data
can be leaked through metadata and many people don't realize it (which
also usually means they don't need it). On the other hand, the people
who realize it are the ones who would explicitly edit the metadata and
check what they want to be exported or not.
This is only a first step. Some people may want to always export the
metadata and for these people, there should be abilities to change the
default.
plug-ins/common/file-png.c | 6 +++---
plug-ins/file-jpeg/jpeg-save.c | 6 +++---
plug-ins/file-tiff/file-tiff.c | 11 +++--------
plug-ins/file-webp/file-webp.c | 6 +++---
4 files changed, 12 insertions(+), 17 deletions(-)
---
diff --git a/plug-ins/common/file-png.c b/plug-ins/common/file-png.c
index da894ea..47d4b2b 100644
--- a/plug-ins/common/file-png.c
+++ b/plug-ins/common/file-png.c
@@ -212,9 +212,9 @@ static const PngSaveVals defaults =
TRUE,
TRUE,
9,
- TRUE, /* save exif */
- TRUE, /* save xmp */
- TRUE, /* save iptc */
+ FALSE, /* save exif */
+ FALSE, /* save xmp */
+ FALSE, /* save iptc */
TRUE, /* save thumbnail */
PNG_FORMAT_AUTO
};
diff --git a/plug-ins/file-jpeg/jpeg-save.c b/plug-ins/file-jpeg/jpeg-save.c
index c38ff5c..9c426f8 100644
--- a/plug-ins/file-jpeg/jpeg-save.c
+++ b/plug-ins/file-jpeg/jpeg-save.c
@@ -64,10 +64,10 @@ static gboolean arithc_supported = FALSE;
#define DEFAULT_RESTART_MCU_ROWS 16
#define DEFAULT_DCT 0
#define DEFAULT_PREVIEW FALSE
-#define DEFAULT_EXIF TRUE
+#define DEFAULT_EXIF FALSE
#define DEFAULT_THUMBNAIL FALSE
-#define DEFAULT_XMP TRUE
-#define DEFAULT_IPTC TRUE
+#define DEFAULT_XMP FALSE
+#define DEFAULT_IPTC FALSE
#define DEFAULT_USE_ORIG_QUALITY FALSE
#define JPEG_DEFAULTS_PARASITE "jpeg-save-defaults"
diff --git a/plug-ins/file-tiff/file-tiff.c b/plug-ins/file-tiff/file-tiff.c
index dfb8eaa..d58d5ba 100644
--- a/plug-ins/file-tiff/file-tiff.c
+++ b/plug-ins/file-tiff/file-tiff.c
@@ -86,9 +86,9 @@ static TiffSaveVals tsvals =
COMPRESSION_NONE, /* compression */
TRUE, /* alpha handling */
TRUE, /* save transp. pixels */
- TRUE, /* save exif */
- TRUE, /* save xmp */
- TRUE, /* save iptc */
+ FALSE, /* save exif */
+ FALSE, /* save xmp */
+ FALSE, /* save iptc */
TRUE /* save thumbnail */
};
@@ -362,11 +362,6 @@ run (const gchar *name,
"image/tiff",
&metadata_flags);
- tsvals.save_exif = (metadata_flags & GIMP_METADATA_SAVE_EXIF) != 0;
- tsvals.save_xmp = (metadata_flags & GIMP_METADATA_SAVE_XMP) != 0;
- tsvals.save_iptc = (metadata_flags & GIMP_METADATA_SAVE_IPTC) != 0;
- tsvals.save_thumbnail = (metadata_flags & GIMP_METADATA_SAVE_THUMBNAIL) != 0;
-
parasite = gimp_image_get_parasite (orig_image, "gimp-comment");
if (parasite)
{
diff --git a/plug-ins/file-webp/file-webp.c b/plug-ins/file-webp/file-webp.c
index 4660248..4c7407b 100644
--- a/plug-ins/file-webp/file-webp.c
+++ b/plug-ins/file-webp/file-webp.c
@@ -199,9 +199,9 @@ run (const gchar *name,
params.kf_distance = 50;
params.quality = 90.0f;
params.alpha_quality = 100.0f;
- params.exif = TRUE;
- params.iptc = TRUE;
- params.xmp = TRUE;
+ params.exif = FALSE;
+ params.iptc = FALSE;
+ params.xmp = FALSE;
params.delay = 200;
params.force_delay = FALSE;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]