[epiphany] window: Make policy decision robust to future decision types



commit 5fbe1607b849c4ce49ad76608a09254cc013a217
Author: Michael Catanzaro <mcatanzaro igalia com>
Date:   Sat Jan 6 18:42:26 2018 -0600

    window: Make policy decision robust to future decision types
    
    The current code will break in the future if any new decision type is
    introduced that does not correspond to a WebKitNavigationPolicyDecision.

 src/ephy-window.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/src/ephy-window.c b/src/ephy-window.c
index 96af170..a700fab 100644
--- a/src/ephy-window.c
+++ b/src/ephy-window.c
@@ -2071,7 +2071,8 @@ decide_policy_cb (WebKitWebView           *web_view,
   WebKitURIRequest *request;
   const char *request_uri;
 
-  if (decision_type == WEBKIT_POLICY_DECISION_TYPE_RESPONSE)
+  if (decision_type != WEBKIT_POLICY_DECISION_TYPE_NAVIGATION_ACTION &&
+      decision_type != WEBKIT_POLICY_DECISION_TYPE_NEW_WINDOW_ACTION)
     return FALSE;
 
   navigation_decision = WEBKIT_NAVIGATION_POLICY_DECISION (decision);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]