[sysadmin-bin: 1/5] mail: move existing code to function



commit 0b4177808406ceefa902c7b6cf67eaf3a05c24e2
Author: Alberts Muktupāvels <alberts muktupavels gmail com>
Date:   Fri Feb 9 16:46:59 2018 +0200

    mail: move existing code to function

 mail/set-topics-svn-commits-list | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
---
diff --git a/mail/set-topics-svn-commits-list b/mail/set-topics-svn-commits-list
index 867bda4..34b405b 100755
--- a/mail/set-topics-svn-commits-list
+++ b/mail/set-topics-svn-commits-list
@@ -17,19 +17,21 @@ from Mailman import Utils
 from Mailman import Errors
 from Mailman import i18n
 
+def get_git_gnome_org_modules():
+    f = urllib.urlopen("http://git.gnome.org/repositories.txt";)
 
-f = urllib.urlopen("http://git.gnome.org/repositories.txt";)
+    # Ensure the URL is sane (readable and plain text)
+    if f.headers.getmaintype() != 'text' or f.headers.status != "":
+        sys.exit(1)
 
-# Ensure the URL is sane (readable and plain text)
-if f.headers.getmaintype() != 'text' or f.headers.status != "":
-    sys.exit(1)
+    modules = f.read()
+    f.close()
 
-modules = f.read()
-modules = modules.strip()
-modules = modules.split("\n")
-modules.sort()
+    modules = modules.strip()
+    return modules.split("\n")
 
-f.close()
+modules = get_git_gnome_org_modules()
+modules.sort()
 
 # Prepare topics variable
 topics = [(module, "^%s$" % re.escape(module), '', 0) for module in modules]
@@ -39,5 +41,3 @@ mlist = MailList.MailList('commits-list')
 mlist.topics = topics
 mlist.Save()
 mlist.Unlock()
-
-


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]