[totem/wip/inigomartinez/meson-improve: 16/16] build: Remove Makefile.plugins file



commit b265c00ed4ff64d10d4e0cc2abc6bb361f3e7fd9
Author: Iñigo Martínez <inigomartinez gmail com>
Date:   Wed Feb 21 12:01:34 2018 +0100

    build: Remove Makefile.plugins file
    
    The Makefile.plugins belongs to autotools which was already removed.
    
    It also contained a procedure to check python files. This has also
    been added to meson with `check_python` target name.

 meson.build                  |    4 ++-
 src/plugins/Makefile.plugins |   63 ------------------------------------------
 src/plugins/check_python.py  |    9 ++++++
 src/plugins/meson.build      |    5 +++
 4 files changed, 17 insertions(+), 64 deletions(-)
---
diff --git a/meson.build b/meson.build
index eb33c1f..b0d0afe 100644
--- a/meson.build
+++ b/meson.build
@@ -181,7 +181,9 @@ config_h.set('ENABLE_MISSING_PLUGIN_INSTALLATION', enable_easy_codec_installatio
 enable_python = get_option('python')
 if enable_python
   assert(import('python3').find_python().found(), 'python3 required for python support')
-  assert(find_program('pylint-3', 'pylint3', 'pylint', required: false).found(), 'pylint required for python 
support')
+
+  pylint = find_program('pylint-3', 'pylint3', 'pylint', required: false)
+  assert(pylint.found(), 'pylint required for python support')
 
   pygobject_dep = dependency('pygobject-3.0', version: '>= 2.90.3')
 
diff --git a/src/plugins/check_python.py b/src/plugins/check_python.py
new file mode 100755
index 0000000..5de9920
--- /dev/null
+++ b/src/plugins/check_python.py
@@ -0,0 +1,9 @@
+#!/usr/bin/env python3
+
+import glob
+import os
+import subprocess
+import sys
+
+for file in glob.glob(os.path.join(sys.argv[2], '**/*.py')):
+  subprocess.call([sys.argv[1], '-d', 'C0111', '-d', 'W0511', '-d', 'F0401', file])
diff --git a/src/plugins/meson.build b/src/plugins/meson.build
index c93cdde..aa63c9d 100644
--- a/src/plugins/meson.build
+++ b/src/plugins/meson.build
@@ -79,6 +79,11 @@ endif
 if enable_python
   plugins_conf = configuration_data()
   plugins_conf.set('GETTEXT_PACKAGE', meson.project_name())
+
+  run_target(
+    'check_python',
+    command: [join_paths(meson.current_source_dir(), 'check_python.py'), pylint.path(), 
meson.current_source_dir()]
+  )
 else
   foreach plugin: python_plugins
     assert(not plugins.contains(plugin), 'python support required for the ' + plugin + ' plugin')


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]