[gnome-music/wip/mschraal/player-factor-out-gstreamer] gstplayer: Remove is_playing function



commit 17c4b6dbef6dba122fbe672cf22d5ab03751e691
Author: Marinus Schraal <mschraal gnome org>
Date:   Fri Feb 16 13:53:40 2018 +0100

    gstplayer: Remove is_playing function
    
    Use state instead.

 gnomemusic/gstplayer.py | 11 -----------
 gnomemusic/player.py    |  6 +++---
 2 files changed, 3 insertions(+), 14 deletions(-)
---
diff --git a/gnomemusic/gstplayer.py b/gnomemusic/gstplayer.py
index f8db433..1541164 100644
--- a/gnomemusic/gstplayer.py
+++ b/gnomemusic/gstplayer.py
@@ -173,17 +173,6 @@ class GstPlayer(GObject.GObject):
     def _on_bus_eos(self, bus, message):
         self.emit('eos')
 
-    @log
-    def is_playing(self):
-        ok, state, pending = self._player.get_state(0)
-
-        if ok == Gst.StateChangeReturn.ASYNC:
-            return pending == Gst.State.PLAYING
-        elif ok == Gst.StateChangeReturn.SUCCESS:
-            return state == Gst.State.PLAYING
-
-        return False
-
     @log
     def _get_playback_status(self):
         ok, state, pending = self._player.get_state(0)
diff --git a/gnomemusic/player.py b/gnomemusic/player.py
index 2a1766f..5ca1389 100644
--- a/gnomemusic/player.py
+++ b/gnomemusic/player.py
@@ -326,7 +326,7 @@ class Player(GObject.GObject):
 
     @property
     def playing(self):
-        return self._player.is_playing()
+        return self._player.state == Playback.PLAYING
 
     @log
     def _on_state_change(self, klass, arguments):
@@ -334,7 +334,7 @@ class Player(GObject.GObject):
 
     @log
     def _sync_playing(self):
-        if self._player.is_playing():
+        if self._player.state == Playback.PLAYING:
             image = self._pause_image
             tooltip = _("Pause")
         else:
@@ -749,7 +749,7 @@ class Player(GObject.GObject):
 
     @log
     def _on_play_button_clicked(self, button):
-        if self._player.is_playing():
+        if self._player.state == Playback.PLAYING:
             self.pause()
         else:
             self.play()


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]