[glib] gfile: Fix FD leak introduced in error path in previous commit



commit a66fc8e3a92d2a28c84319e3f35c77062379db68
Author: Philip Withnall <withnall endlessm com>
Date:   Fri Feb 16 12:03:47 2018 +0000

    gfile: Fix FD leak introduced in error path in previous commit
    
    The hazards of ‘just a quick fix and I will push’.
    
    Signed-off-by: Philip Withnall <withnall endlessm com>
    Reviewed-by: nobody

 gio/gfile.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/gio/gfile.c b/gio/gfile.c
index fcbbff22e..334ad8ec3 100644
--- a/gio/gfile.c
+++ b/gio/gfile.c
@@ -3025,7 +3025,8 @@ splice_stream_with_progress (GInputStream           *in,
         {
           g_set_error (error, G_IO_ERROR, g_io_error_from_errno (errsv),
                        _("Error splicing file: %s"), g_strerror (errsv));
-          return FALSE;
+          res = FALSE;
+          goto out;
         }
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]