[gnome-builder] build-manager: protect against disposal



commit bef2c3e42e4fd91f169b12e445c1dd9c8ed11bd8
Author: Christian Hergert <chergert redhat com>
Date:   Tue Feb 13 15:23:41 2018 -0800

    build-manager: protect against disposal
    
    We might have lost our timer before our callback, so ensure that we check
    for a valid timer first. No need to notify if we lost it.

 src/libide/buildsystem/ide-build-manager.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/src/libide/buildsystem/ide-build-manager.c b/src/libide/buildsystem/ide-build-manager.c
index 7308bca9f..0f6a83389 100644
--- a/src/libide/buildsystem/ide-build-manager.c
+++ b/src/libide/buildsystem/ide-build-manager.c
@@ -178,10 +178,13 @@ ide_build_manager_stop_timer (IdeBuildManager *self)
 
   g_assert (IDE_IS_BUILD_MANAGER (self));
 
-  g_timer_stop (self->running_time);
   dzl_clear_source (&self->timer_source);
 
-  g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_RUNNING_TIME]);
+  if (self->running_time != NULL)
+    {
+      g_timer_stop (self->running_time);
+      g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_RUNNING_TIME]);
+    }
 
   IDE_EXIT;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]