[gimp] Bug 783755 - Smudge should blend the smudged colors using linear RGB



commit 6f324b867af50898bfb40abc0f4dcfd83bdc21ea
Author: Michael Natterer <mitch gimp org>
Date:   Mon Feb 12 17:27:05 2018 +0100

    Bug 783755 - Smudge should blend the smudged colors using linear RGB
    
    This reverts commit 94c6bb46030e544f5f9267cd08bdd15fc84fee8a, because
    unlike what the bug title suggests, Smudge apparently *should* use
    perceptual RGB, so now everything works as before.

 app/paint/gimpheal.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/app/paint/gimpheal.c b/app/paint/gimpheal.c
index 71a9fd9..e0e50a0 100644
--- a/app/paint/gimpheal.c
+++ b/app/paint/gimpheal.c
@@ -196,9 +196,9 @@ gimp_heal_sub (GeglBuffer          *top_buffer,
   gint                n_components = babl_format_get_n_components (format);
 
   if (n_components == 2)
-    format = babl_format ("YA float");
+    format = babl_format ("Y'A float");
   else if (n_components == 4)
-    format = babl_format ("RGBA float");
+    format = babl_format ("R'G'B'A float");
   else
     g_return_if_reached ();
 
@@ -239,9 +239,9 @@ gimp_heal_add (GeglBuffer          *first_buffer,
   gint                n_components = babl_format_get_n_components (format);
 
   if (n_components == 2)
-    format = babl_format ("YA float");
+    format = babl_format ("Y'A float");
   else if (n_components == 4)
-    format = babl_format ("RGBA float");
+    format = babl_format ("R'G'B'A float");
   else
     g_return_if_reached ();
 
@@ -552,10 +552,11 @@ gimp_heal_motion (GimpSourceCore   *source_core,
       return;
     }
 
+  /*  heal should work in perceptual space, use R'G'B' instead of RGB  */
   src_copy = gegl_buffer_new (GEGL_RECTANGLE (0, 0,
                                               src_rect->width,
                                               src_rect->height),
-                              babl_format ("RGBA float"));
+                              babl_format ("R'G'B'A float"));
 
   gegl_buffer_copy (src_buffer, src_rect, GEGL_ABYSS_NONE,
                     src_copy,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]